* [PATCH] src: expr: log: fixed error in nft_rule_expr_log_build
@ 2013-11-19 16:56 Ana Rey
2013-11-19 20:11 ` Pablo Neira Ayuso
0 siblings, 1 reply; 2+ messages in thread
From: Ana Rey @ 2013-11-19 16:56 UTC (permalink / raw)
To: netfilter-devel
If I run my automatic unit test of libnftable, It shows:
"ERROR: Expr NFT_EXPR_LOG_PREFIX mismatches"
a: test
b: test\x06
The problem was in nft_rule_expr_log_build function.
With the attached patch, we use "mnl_attr_put_strz" in instead of
"mnl_attr_put_str".
---
src/expr/log.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/expr/log.c b/src/expr/log.c
index 495c1bd..76657a9 100644
--- a/src/expr/log.c
+++ b/src/expr/log.c
@@ -119,7 +119,7 @@ nft_rule_expr_log_build(struct nlmsghdr *nlh, struct nft_rule_expr *e)
struct nft_expr_log *log = nft_expr_data(e);
if (e->flags & (1 << NFT_EXPR_LOG_PREFIX))
- mnl_attr_put_str(nlh, NFTA_LOG_PREFIX, log->prefix);
+ mnl_attr_put_strz(nlh, NFTA_LOG_PREFIX, log->prefix);
if (e->flags & (1 << NFT_EXPR_LOG_GROUP))
mnl_attr_put_u16(nlh, NFTA_LOG_GROUP, htons(log->group));
if (e->flags & (1 << NFT_EXPR_LOG_SNAPLEN))
--
1.8.4.rc3
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] src: expr: log: fixed error in nft_rule_expr_log_build
2013-11-19 16:56 [PATCH] src: expr: log: fixed error in nft_rule_expr_log_build Ana Rey
@ 2013-11-19 20:11 ` Pablo Neira Ayuso
0 siblings, 0 replies; 2+ messages in thread
From: Pablo Neira Ayuso @ 2013-11-19 20:11 UTC (permalink / raw)
To: Ana Rey; +Cc: netfilter-devel
On Tue, Nov 19, 2013 at 05:56:18PM +0100, Ana Rey wrote:
> If I run my automatic unit test of libnftable, It shows:
> "ERROR: Expr NFT_EXPR_LOG_PREFIX mismatches"
> a: test
> b: test\x06
>
> The problem was in nft_rule_expr_log_build function.
>
> With the attached patch, we use "mnl_attr_put_strz" in instead of
> "mnl_attr_put_str".
Applied, thanks.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-11-19 20:11 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-11-19 16:56 [PATCH] src: expr: log: fixed error in nft_rule_expr_log_build Ana Rey
2013-11-19 20:11 ` Pablo Neira Ayuso
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).