netfilter-devel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Florian Westphal <fw@strlen.de>
To: Ken-ichirou MATSUZAWA <chamaken@gmail.com>
Cc: Pablo Neira Ayuso <pablo@netfilter.org>, netfilter-devel@vger.kernel.org
Subject: Re: libmnl [PATCH 2/5] examples: fix trivial error message
Date: Thu, 5 Dec 2013 15:27:46 +0100	[thread overview]
Message-ID: <20131205142746.GH2767@breakpoint.cc> (raw)
In-Reply-To: <CAGCkEt1+dni9L0-5OYsPnoOhBZGB6XaRSQ9T_GKifSE4pwC_PQ@mail.gmail.com>

Ken-ichirou MATSUZAWA <chamaken@gmail.com> wrote:
> From: Ken-ichirou MATSUZAWA <chamas@h4.dion.ne.jp>
> Date: Thu, 7 Nov 2013 16:52:15 +0900
> Subject: [PATCH 2/5] examples: fix trivial error message

Something corrupted the patch formattig, breaking long lines,
converting tabs/spaces, etc:
patch: **** malformed patch at line 45: *attr, void *data)

> index a862912..901bd80 100644
> --- a/examples/netfilter/nf-log.c
> +++ b/examples/netfilter/nf-log.c
> @@ -39,14 +39,14 @@ static int parse_attr_cb(const struct nlattr
> *attr, void *data)

Here for example.

It would be nice if you could fix this (mail patch to yourself,
then check if it applies via 'patch -p1' or 'git am'.

If you resend, can you also include a 'Signed-off-by' tag?

After that, we can apply your change.

Thanks!

  reply	other threads:[~2013-12-05 14:27 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-12-05 10:16 libmnl [PATCH 2/5] examples: fix trivial error message Ken-ichirou MATSUZAWA
2013-12-05 14:27 ` Florian Westphal [this message]
2013-12-05 22:42   ` Ken-ichirou MATSUZAWA

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20131205142746.GH2767@breakpoint.cc \
    --to=fw@strlen.de \
    --cc=chamaken@gmail.com \
    --cc=netfilter-devel@vger.kernel.org \
    --cc=pablo@netfilter.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).