netfilter-devel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Patrick McHardy <kaber@trash.net>
Cc: "Nicki P." <xastx@gmx.de>, netfilter-devel@vger.kernel.org
Subject: Re: ipt_SYNPROXY: kernel panic caused by nullpointer dereference
Date: Wed, 11 Dec 2013 11:33:04 +0100	[thread overview]
Message-ID: <20131211103304.GA7540@localhost> (raw)
In-Reply-To: <20131208165231.GA1564@macbook.localnet>

On Sun, Dec 08, 2013 at 04:52:31PM +0000, Patrick McHardy wrote:
> On Sun, Dec 08, 2013 at 11:01:46AM +0100, Pablo Neira Ayuso wrote:
> > On Sun, Dec 08, 2013 at 08:16:00AM +0100, Nicki P. wrote:
> > > hi,
> > > 
> > > when activating ipt_SYNPROXY with:
> > > iptables -t raw -A PREROUTING -p tcp -d 1.2.3.4 --dport 80 --tcp-flags
> > > SYN,ACK,RST,FIN SYN -j SYNPROXY
> > >
> > > and sending a SYN packet to port 80:
> > > hping3 -S -d 64 1.2.3.4 -p 80
> > > 
> > > I get kernel panic:
> > > http://goo.gl/L6dCz6
> > >
> > > I'm using kernel v3.12.2 and iptables v1.4.21. Am I doing something wrong,
> > > or is it a bug?
> > 
> > You have to run this from the INPUT/FORWARD chain, SYNPROXY needs the
> > routing information to work.
> 
> Let's fix that:
> 
> From e5b31e75df3c3f9629900016a95336c04165d13f Mon Sep 17 00:00:00 2001
> From: Patrick McHardy <kaber@trash.net>
> Date: Sun, 8 Dec 2013 16:49:36 +0000
> Subject: [PATCH] netfilter: SYNPROXY target: restrict to INPUT/FORWARD
> 
> Fix a crash in synproxy_send_tcp() when using the SYNPROXY target in the
> PREROUTING chain caused by missing routing information.

Applied, thanks Patrick!

      reply	other threads:[~2013-12-11 10:33 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-12-08  7:16 ipt_SYNPROXY: kernel panic caused by nullpointer dereference Nicki P.
2013-12-08 10:01 ` Pablo Neira Ayuso
2013-12-08 16:52   ` Patrick McHardy
2013-12-11 10:33     ` Pablo Neira Ayuso [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20131211103304.GA7540@localhost \
    --to=pablo@netfilter.org \
    --cc=kaber@trash.net \
    --cc=netfilter-devel@vger.kernel.org \
    --cc=xastx@gmx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).