From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Fan Du <fan.du@windriver.com>
Cc: davem@davemloft.net, steffen.klassert@secunet.com,
netfilter-devel@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [PATCH net-next 0/2] netfilter: IPv4/v6 IPcomp match support
Date: Tue, 17 Dec 2013 14:05:55 +0100 [thread overview]
Message-ID: <20131217130555.GA8874@localhost> (raw)
In-Reply-To: <1386937082-30412-1-git-send-email-fan.du@windriver.com>
On Fri, Dec 13, 2013 at 08:18:00PM +0800, Fan Du wrote:
> Hi,
>
> This patchset adds IPv4/v6 IPComp 'match' plugin to enables user setting
> ACTONs for IPcomp flows sepecified with SPI value.
>
> Corresponding iptables patchset will be sent here after soon.
>
> Fan Du (2):
> netfilter: add IPv4 IPComp extension match support
> netfilter: add IPv6 IPComp extension match support
This looks good, but I have to ask you to merge those two modules into
one single xt_ipcomp, they are fairly small and we can save the
overhead of having two different modules. Moreover, at quick glance I
don't see any dependency with IPv4/IPv6 exported symbols that may
cause ifdef pollution.
Please, see net/netfilter/xt_tcpudp.c as reference to rework this.
Thanks.
next prev parent reply other threads:[~2013-12-17 13:05 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-13 12:18 [PATCH net-next 0/2] netfilter: IPv4/v6 IPcomp match support Fan Du
2013-12-13 12:18 ` [PATCH 1/2] netfilter: add IPv4 IPComp extension " Fan Du
2013-12-13 12:18 ` [PATCH 2/2] netfilter: add IPv6 " Fan Du
2013-12-17 13:05 ` Pablo Neira Ayuso [this message]
2013-12-19 3:30 ` [PATCH net-next 0/2] netfilter: IPv4/v6 IPcomp " Fan Du
2013-12-20 9:04 ` Pablo Neira Ayuso
2013-12-20 9:21 ` Fan Du
2013-12-23 12:13 ` Pablo Neira Ayuso
2013-12-24 6:19 ` Fan Du
2013-12-24 18:16 ` Pablo Neira Ayuso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131217130555.GA8874@localhost \
--to=pablo@netfilter.org \
--cc=davem@davemloft.net \
--cc=fan.du@windriver.com \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=steffen.klassert@secunet.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).