From mboxrd@z Thu Jan 1 00:00:00 1970 From: Pablo Neira Ayuso Subject: Re: [PATCH 2/3] netfilter: nf_tables: limit maximum number of elements Date: Sun, 5 Jan 2014 23:15:40 +0100 Message-ID: <20140105221540.GA4495@localhost> References: <1388956728-6754-1-git-send-email-pablo@netfilter.org> <1388956728-6754-3-git-send-email-pablo@netfilter.org> <20140105215102.GA18661@macbook.localnet> <20140105221404.GA4466@localhost> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: netfilter-devel@vger.kernel.org To: Patrick McHardy Return-path: Received: from mail.us.es ([193.147.175.20]:53888 "EHLO mail.us.es" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751640AbaAEWPo (ORCPT ); Sun, 5 Jan 2014 17:15:44 -0500 Content-Disposition: inline In-Reply-To: <20140105221404.GA4466@localhost> Sender: netfilter-devel-owner@vger.kernel.org List-ID: On Sun, Jan 05, 2014 at 11:14:04PM +0100, Pablo Neira Ayuso wrote: > On Sun, Jan 05, 2014 at 09:51:02PM +0000, Patrick McHardy wrote: > > On Sun, Jan 05, 2014 at 10:18:47PM +0100, Pablo Neira Ayuso wrote: > > > This patch adds a limit to the maximum number of elements that > > > belong to a set. It also adds a new field to count the current > > > number of elements, so in case that limit is reached, we hit > > > -ENOSPC. > > > > > > This patch also adds two new attributes: NFTA_SET_MAXELEMS to > > > set and to indicate the current limit and NFTA_SET_NUMELEMS > > > to export the current number of set elements. > > > > This affects the API, I'm really opposed to make any temporary > > fixes, but any temporary fix affecting the API is a complete > > no go IMO. > > We need to limit elements in a set. I think it's not good that you can > add an unlimited number of sets, right? (I meant to say) ... an unlimited number of elements > This patch is independent of 1/3, which can be discarded. But 3/3 > relies on it. > -- > To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html