netfilter-devel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Kristian Evensen <kristian.evensen@gmail.com>
Cc: netfilter-devel@vger.kernel.org
Subject: Re: [PATCH netfilter: nft] add connmark module
Date: Mon, 6 Jan 2014 14:09:19 +0100	[thread overview]
Message-ID: <20140106130919.GA8238@localhost> (raw)
In-Reply-To: <CAKfDRXi1UYX120_ndw_hCNVyB2X+TEAOiUTamG3ZNw-vBruv9A@mail.gmail.com>

On Mon, Jan 06, 2014 at 02:02:55PM +0100, Kristian Evensen wrote:
> Yes, that sounds like a better solution. I will get started on adding
> this functionality. One question though, how should we deal with the
> masks? Based on my limited understanding, it is only possible to store
> one value per meta key.

Please, check the bitwise expression (net/netfilter/nft_bitwise.c), it
provides an instruction to perform bitwise operations.

> Also, what would be the preferred syntax? When looking at the existing
> meta set/get, I suggest something like the following:
> 
> ... meta connmark set X
> ... meta connmark-restore
> ... meta connmark-save.

Unless someone else come with a better syntax proposal, that's fine
with me.

P.S: Please, don't top post:
http://www.netfilter.org/mailinglists.html#list-rules

  reply	other threads:[~2014-01-06 13:09 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-01-06 12:29 [PATCH netfilter: nft] add connmark module Kristian Evensen
2014-01-06 12:42 ` Pablo Neira Ayuso
2014-01-06 12:46   ` Kristian Evensen
2014-01-06 12:49     ` Pablo Neira Ayuso
2014-01-06 13:02       ` Kristian Evensen
2014-01-06 13:09         ` Pablo Neira Ayuso [this message]
2014-01-06 13:11           ` Kristian Evensen
2014-01-06 15:19       ` Kristian Evensen
2014-01-06 16:05         ` Kristian Evensen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140106130919.GA8238@localhost \
    --to=pablo@netfilter.org \
    --cc=kristian.evensen@gmail.com \
    --cc=netfilter-devel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).