netfilter-devel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Patrick McHardy <kaber@trash.net>
To: Kristian Evensen <kristian.evensen@gmail.com>
Cc: Florian Westphal <fw@strlen.de>, netfilter-devel@vger.kernel.org
Subject: Re: [PATCH netfilter: nft] Add the connmark meta_key
Date: Mon, 6 Jan 2014 18:19:28 +0000	[thread overview]
Message-ID: <20140106181928.GA19666@macbook.localnet> (raw)
In-Reply-To: <CAKfDRXir46pGb8-YpdW54RMgkdB11YEmqR_VNMJd3CTJKEo6TQ@mail.gmail.com>

On Mon, Jan 06, 2014 at 07:09:58PM +0100, Kristian Evensen wrote:
> Hello,
> 
> On Mon, Jan 6, 2014 at 6:15 PM, Patrick McHardy <kaber@trash.net> wrote:
> > Well, actually the ct expression already supports connmark, as does userspace.
> >
> > #ifdef CONFIG_NF_CONNTRACK_MARK
> >         case NFT_CT_MARK:
> >                 dest->data[0] = ct->mark;
> >                 return;
> > #endif
> 
> Thank you very much for pointing this out. I will change my approach
> and add a set command in ct (similar to what was recently added to
> meta). Or is someone already working on this?

Not sure what you're trying to achieve, we already support the connmark
in the ct expression:

nft filter output ct mark 0x1 ...

  reply	other threads:[~2014-01-06 18:19 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-01-06 16:57 [PATCH netfilter: nft] Add the connmark meta_key Kristian Evensen
2014-01-06 17:04 ` Patrick McHardy
2014-01-06 17:05 ` Florian Westphal
2014-01-06 17:15   ` Patrick McHardy
2014-01-06 18:09     ` Kristian Evensen
2014-01-06 18:19       ` Patrick McHardy [this message]
2014-01-06 19:25         ` Kristian Evensen
2014-01-06 20:54           ` Patrick McHardy
2014-01-06 21:00             ` Kristian Evensen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140106181928.GA19666@macbook.localnet \
    --to=kaber@trash.net \
    --cc=fw@strlen.de \
    --cc=kristian.evensen@gmail.com \
    --cc=netfilter-devel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).