From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Arturo Borrero Gonzalez <arturo.borrero.glez@gmail.com>
Cc: Alvaro Neira <alvaroneay@gmail.com>,
Netfilter Development Mailing list
<netfilter-devel@vger.kernel.org>
Subject: Re: [libnftables PATCH v2] src: new error reporting approach for XML/JSON parsers
Date: Tue, 7 Jan 2014 00:35:53 +0100 [thread overview]
Message-ID: <20140106233553.GA25742@localhost> (raw)
In-Reply-To: <CAOkSjBgQt_=obGONgOUmOM+yCXJ7bxK3f1-ZYSmP2089DzddmA@mail.gmail.com>
On Mon, Jan 06, 2014 at 11:46:46PM +0100, Arturo Borrero Gonzalez wrote:
> On 6 January 2014 13:23, Pablo Neira Ayuso <pablo@netfilter.org> wrote:
> > On Mon, Jan 06, 2014 at 12:51:14AM +0100, Alvaro Neira wrote:
> >> From: Álvaro Neira Ayuso <alvaroneay@gmail.com>
> >>
> >> I have added a new structure for reporting some errors in parser
> >> that we can't cover with errno.
> >>
> >> In this patch, we have three errors that we can't cover with errno:
> >>
> >> NFT_PARSE_EBADINPUT : Bad XML/JSON format in the input
> >> NFT_PARSE_EMISSINGNODE : Missing node in our input
> >> NFT_PARSE_EBADTYPE : Wrong type value in a node
> >
> > This looks good. Applied, thanks Alvaro.
>
> Hi Pablo,
>
> I don't see this applied:
>
> ~/libnftables$ git pull --rebase
> Current branch master is up to date.
> ~/libnftables$ gldoc
> * b4a0d19 (HEAD, origin/master, origin/HEAD, master) src: rename the
> parameter tag to node_name in jansson function
> * 24e08e5 build: properly handle --without-{xml,json}-parsing
> * 2307124 include: update netlink.h to 3.13
> [...]
Forgot to push it, here it is:
http://git.netfilter.org/libnftables/commit/?id=e87d2f9ef8a4a298de5514b30ec2d43d3c90a644
--
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
prev parent reply other threads:[~2014-01-06 23:35 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-05 23:51 [libnftables PATCH v2] src: new error reporting approach for XML/JSON parsers Alvaro Neira
2014-01-06 12:23 ` Pablo Neira Ayuso
2014-01-06 22:46 ` Arturo Borrero Gonzalez
2014-01-06 23:35 ` Pablo Neira Ayuso [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140106233553.GA25742@localhost \
--to=pablo@netfilter.org \
--cc=alvaroneay@gmail.com \
--cc=arturo.borrero.glez@gmail.com \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).