From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Arturo Borrero Gonzalez <arturo.borrero.glez@gmail.com>
Cc: Netfilter Development Mailing list <netfilter-devel@vger.kernel.org>
Subject: Re: [libnftables PATCH 3/6] internal: rework parsing symbol logic
Date: Wed, 8 Jan 2014 13:25:28 +0100 [thread overview]
Message-ID: <20140108122528.GA25406@localhost> (raw)
In-Reply-To: <CAOkSjBibj-66qf2mr=26d1GPfASJFjb+9Bbyv2LOsi3rUkuyYw@mail.gmail.com>
On Wed, Jan 08, 2014 at 01:20:51PM +0100, Arturo Borrero Gonzalez wrote:
> On 8 January 2014 00:18, Pablo Neira Ayuso <pablo@netfilter.org> wrote:
> >
> > We don't save any ifdef.
>
> Well, we need at least one ifdef per format. I don't see how we can
> get rid of them.
>
> This patch just condensates the logic to one single point, also adding
> the void definition, which is good for other patches in the series.
OK, then you have to include in the description that it simplifies
follow-up patches and in what way.
But I also rised some concerns on the follow-up patches that you have
to address.
next prev parent reply other threads:[~2014-01-08 12:25 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-07 11:47 [libnftables PATCH 0/6] parsing update Arturo Borrero Gonzalez
2014-01-07 11:47 ` [libnftables PATCH 1/6] mxml: add error reference of the top node Arturo Borrero Gonzalez
2014-01-07 23:16 ` Pablo Neira Ayuso
2014-01-07 11:47 ` [libnftables PATCH 2/6] set_elem: add json parsing to API Arturo Borrero Gonzalez
2014-01-07 23:16 ` Pablo Neira Ayuso
2014-01-07 11:47 ` [libnftables PATCH 3/6] internal: rework parsing symbol logic Arturo Borrero Gonzalez
2014-01-07 23:18 ` Pablo Neira Ayuso
2014-01-08 12:20 ` Arturo Borrero Gonzalez
2014-01-08 12:25 ` Pablo Neira Ayuso [this message]
2014-01-07 11:47 ` [libnftables PATCH 4/6] internal: add a selector for parsing ops Arturo Borrero Gonzalez
2014-01-07 23:29 ` Pablo Neira Ayuso
2014-01-08 12:31 ` Arturo Borrero Gonzalez
2014-01-08 13:36 ` Pablo Neira Ayuso
2014-01-07 11:47 ` [libnftables PATCH 5/6] parsing: add interface to parse from file Arturo Borrero Gonzalez
2014-01-07 11:47 ` [libnftables PATCH 6/6] tests: update tests with nft_*_parse_file() Arturo Borrero Gonzalez
2014-01-07 23:32 ` Pablo Neira Ayuso
2014-01-08 12:21 ` Arturo Borrero Gonzalez
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140108122528.GA25406@localhost \
--to=pablo@netfilter.org \
--cc=arturo.borrero.glez@gmail.com \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).