From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Arturo Borrero Gonzalez <arturo.borrero.glez@gmail.com>
Cc: Kristian Evensen <kristian.evensen@gmail.com>,
Netfilter Development Mailing list
<netfilter-devel@vger.kernel.org>
Subject: Re: [PATCH libnftables v2] Add support for ct set
Date: Fri, 10 Jan 2014 12:30:43 +0100 [thread overview]
Message-ID: <20140110113043.GA6372@localhost> (raw)
In-Reply-To: <CAOkSjBjFnfRhQ+3seVLx_i-JrzdQwcefD_U_COByX=EidOoXBw@mail.gmail.com>
On Fri, Jan 10, 2014 at 12:06:29PM +0100, Arturo Borrero Gonzalez wrote:
> On 10 January 2014 11:37, Pablo Neira Ayuso <pablo@netfilter.org> wrote:
> >
> > That's inconsistent and needs to be fixed. My suggestion is to fix it
> > by using u32 for registers. Thanks.
>
> cmp [0] also uses uint8_t for a register.
>
> Also, others [1] use 'enum nft_registers'.
>
> Should I patch all and switch to enum nft_registers?
Yes please, go ahead review that. Thanks.
next prev parent reply other threads:[~2014-01-10 11:31 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-08 8:36 [PATCH libnftables v2] Add support for ct set Kristian Evensen
2014-01-10 0:50 ` Pablo Neira Ayuso
2014-01-10 8:26 ` Kristian Evensen
2014-01-10 10:37 ` Pablo Neira Ayuso
2014-01-10 11:06 ` Arturo Borrero Gonzalez
2014-01-10 11:30 ` Pablo Neira Ayuso [this message]
2014-01-10 11:37 ` Kristian Evensen
2014-01-10 11:42 ` Arturo Borrero Gonzalez
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140110113043.GA6372@localhost \
--to=pablo@netfilter.org \
--cc=arturo.borrero.glez@gmail.com \
--cc=kristian.evensen@gmail.com \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).