From: Patrick McHardy <kaber@trash.net>
To: Kristian Evensen <kristian.evensen@gmail.com>
Cc: netfilter-devel@vger.kernel.org
Subject: Re: [PATCH libnftables] Add support for ct set
Date: Fri, 10 Jan 2014 13:14:06 +0000 [thread overview]
Message-ID: <20140110131406.GA8088@macbook.localnet> (raw)
In-Reply-To: <1389359425-6837-1-git-send-email-kristian.evensen@gmail.com>
On Fri, Jan 10, 2014 at 02:10:25PM +0100, Kristian Evensen wrote:
> #define NFTA_CT_MAX (__NFTA_CT_MAX - 1)
> diff --git a/src/expr/ct.c b/src/expr/ct.c
> index 46e3cef..02a073e 100644
> --- a/src/expr/ct.c
> +++ b/src/expr/ct.c
> @@ -24,7 +24,8 @@
>
> struct nft_expr_ct {
> enum nft_ct_keys key;
> - uint32_t dreg; /* enum nft_registers */
> + enum nft_registers dreg;
> + enum nft_registers sreg;
> uint8_t dir;
> };
nftables uses statements for things that don't return a value. I think
it would make sense to keep this consistent. An "set" expression (aka
statement) can never be used in a match, so its something fundamentally
different than an expression.
next prev parent reply other threads:[~2014-01-10 13:14 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-10 13:10 [PATCH libnftables] Add support for ct set Kristian Evensen
2014-01-10 13:14 ` Patrick McHardy [this message]
2014-01-10 13:19 ` Kristian Evensen
2014-01-10 13:27 ` Patrick McHardy
2014-01-10 13:33 ` Kristian Evensen
2014-01-10 13:43 ` Patrick McHardy
2014-01-10 13:52 ` Patrick McHardy
2014-01-10 14:03 ` Kristian Evensen
2014-01-10 13:54 ` Pablo Neira Ayuso
2014-01-10 13:58 ` Patrick McHardy
2014-01-10 14:32 ` Pablo Neira Ayuso
2014-01-10 18:06 ` Patrick McHardy
2014-01-10 19:10 ` Pablo Neira Ayuso
2014-01-10 19:20 ` Patrick McHardy
-- strict thread matches above, loose matches on Subject: below --
2014-01-07 15:15 Kristian Evensen
2014-01-07 17:13 ` Arturo Borrero Gonzalez
2014-01-07 17:28 ` Kristian Evensen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140110131406.GA8088@macbook.localnet \
--to=kaber@trash.net \
--cc=kristian.evensen@gmail.com \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).