* [PATCH] nftables: Drop hard coded install using root user owner and group.
@ 2014-01-13 2:42 Kevin Fenzi
2014-01-13 6:37 ` Patrick McHardy
0 siblings, 1 reply; 2+ messages in thread
From: Kevin Fenzi @ 2014-01-13 2:42 UTC (permalink / raw)
To: netfilter-devel
[-- Attachment #1: Type: text/plain, Size: 2241 bytes --]
Packaging systems build as a non priv user, so can't install as root. Users
installing from source can 'sudo make install' or run 'make install' as root
Signed-off-by: Kevin Fenzi <kevin@scrye.com>
---
Makefile.rules.in | 2 +-
doc/Makefile.in | 4 ++--
files/Makefile.in | 2 +-
3 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/Makefile.rules.in b/Makefile.rules.in
index a93a26b..4a5d413 100644
--- a/Makefile.rules.in
+++ b/Makefile.rules.in
@@ -61,7 +61,7 @@ clean_targets += $(1)-clean
$(1)-install:
@echo -e " INSTALL\t$1"
$(MKDIR_P) $$(DESTDIR)/$$($(1)-destdir)
- $(INSTALL) -m 755 -o root -g root \
+ $(INSTALL) -m 755 \
$(SUBDIR)$(1) \
$$(DESTDIR)/$$($(1)-destdir)/$(1)
install_targets += $(1)-install
diff --git a/doc/Makefile.in b/doc/Makefile.in
index 2c42d7e..c8c5743 100644
--- a/doc/Makefile.in
+++ b/doc/Makefile.in
@@ -10,11 +10,11 @@ install: $(mandocs-y) $(pdfdocs-y)
@echo -e " INSTALL\tdoc"
if test -n "$(mandocs-y)"; then \
$(MKDIR_P) $(DESTDIR)/${mandir}/man8 ;\
- $(INSTALL) -m 755 -o root -g root $(mandocs-y) \
+ $(INSTALL) -m 755 $(mandocs-y) \
$(DESTDIR)/${mandir}/man8/ ;\
fi
if test -n "$(pdfdocs-y)"; then \
$(MKDIR_P) $(DESTDIR)/${pdfdir} ;\
- $(INSTALL) -m 755 -o root -g root $(pdfdocs-y) \
+ $(INSTALL) -m 755 $(pdfdocs-y) \
$(DESTDIR)/${pdfdir}/ ;\
fi
diff --git a/files/Makefile.in b/files/Makefile.in
index cd67c37..0d3390e 100644
--- a/files/Makefile.in
+++ b/files/Makefile.in
@@ -1,4 +1,4 @@
install:
@echo -e " INSTALL\tfiles"
$(MKDIR_P) $(DESTDIR)/$(confdir)
- $(INSTALL) -m 755 -o root -g root $(SUBDIR)nftables/* $(DESTDIR)/$(confdir)/
+ $(INSTALL) -m 755 $(SUBDIR)nftables/* $(DESTDIR)/$(confdir)/
--
1.8.5.2
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] nftables: Drop hard coded install using root user owner and group.
2014-01-13 2:42 [PATCH] nftables: Drop hard coded install using root user owner and group Kevin Fenzi
@ 2014-01-13 6:37 ` Patrick McHardy
0 siblings, 0 replies; 2+ messages in thread
From: Patrick McHardy @ 2014-01-13 6:37 UTC (permalink / raw)
To: Kevin Fenzi; +Cc: netfilter-devel
On Sun, Jan 12, 2014 at 07:42:11PM -0700, Kevin Fenzi wrote:
> Packaging systems build as a non priv user, so can't install as root. Users
> installing from source can 'sudo make install' or run 'make install' as root
Applied, thanks.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-01-13 6:37 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-01-13 2:42 [PATCH] nftables: Drop hard coded install using root user owner and group Kevin Fenzi
2014-01-13 6:37 ` Patrick McHardy
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).