From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Patrick McHardy <kaber@trash.net>, f@localhost
Cc: netfilter-devel@vger.kernel.org
Subject: Re: [PATCH nft] expression: fix output of verdict maps
Date: Tue, 14 Jan 2014 12:29:51 +0100 [thread overview]
Message-ID: <20140114112951.GA6270@localhost> (raw)
In-Reply-To: <20140114090009.GB23920@macbook.localnet>
On Tue, Jan 14, 2014 at 09:00:09AM +0000, Patrick McHardy wrote:
> On Mon, Jan 13, 2014 at 12:42:03PM +0000, Patrick McHardy wrote:
> > On Mon, Jan 13, 2014 at 01:39:16PM +0100, Pablo Neira Ayuso wrote:
> > > % nft list table filter
> > > table ip filter {
> > > ...
> > > chain output {
> > > ...
> > > ip saddr map { 1.1.1.1 => accept}
> > > }
> > > }
> > >
> > > It displays 'map' instead of 'vmap'. Fix it by checking the mapping
> > > type in map_expr_print().
> >
> > The fix is fine of course, but even better would be to get rid of the
> > vmap keyword IMO. IIRC it only exists because I couldn't manage to get
> > a conflict free grammar together, but it would be worth another try.
>
> Actually this works fine. Is there agreement on removing the VMAP keyword?
> If so we should do it before the 0.099 release.
Sure, go ahead. I like it :) and it's consistent with other data maps.
next prev parent reply other threads:[~2014-01-14 11:30 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-13 12:39 [PATCH nft] expression: fix output of verdict maps Pablo Neira Ayuso
2014-01-13 12:42 ` Patrick McHardy
2014-01-14 9:00 ` Patrick McHardy
2014-01-14 11:29 ` Pablo Neira Ayuso [this message]
2014-01-14 12:33 ` Patrick McHardy
2014-01-16 16:53 ` Pablo Neira Ayuso
2014-01-16 16:57 ` Patrick McHardy
2014-01-16 17:03 ` Pablo Neira Ayuso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140114112951.GA6270@localhost \
--to=pablo@netfilter.org \
--cc=f@localhost \
--cc=kaber@trash.net \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).