netfilter-devel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* nftables/libnftables packages for Fedora
@ 2014-01-12 20:40 Kevin Fenzi
  2014-01-12 21:16 ` Arturo Borrero Gonzalez
                   ` (3 more replies)
  0 siblings, 4 replies; 16+ messages in thread
From: Kevin Fenzi @ 2014-01-12 20:40 UTC (permalink / raw)
  To: netfilter-devel


[-- Attachment #1.1: Type: text/plain, Size: 2516 bytes --]

Greetings. 

I apologize in advance if this is not the right place to discuss this.
If it's not, please point me the right direction and I will move it
there. :) 

I am packaging up libnftables/nftables for Fedora. 

libnftables has already passed review: 
https://bugzilla.redhat.com/show_bug.cgi?id=1036319

and nftables has yet to be reviewed: 
https://bugzilla.redhat.com/show_bug.cgi?id=1036320
but has some comments. (more always welcome)

I have some questions/comments/suggestions based on the packaging that
I thought would be good to run by nftables developers. 

1. Completely minor, but noted in review of both packages that the
COPYING file has the old fsf address in it. Would be great if you could
update to the new one. 
https://fedoraproject.org/wiki/Common_Rpmlint_issues#incorrect-fsf-address

2. There is some question about the /etc/nftables/* scripts. In Fedora
land, things in /etc/ should be config files, but these aren't really
config files. They call nft without a full path (/usr/sbin/nft, etc).
Should these really be in /usr/share ? or is it expected users will
modify them? Could you clarify the use case there?

3. nftables hard codes installing as root, which is no good for
building packages (patch attached that just removes the owner/group
setting there). 

4. nftables sets make to '-s' (ie, silent) on subdirs. It's good for
building packages to have verbose output in build logs. Would it be
possible to remove that? If not I can patch it out here. 

5. Is there currently, or planned any version coupling between
libnftables and nftables? Obviously we want them to stay somewhat
close, but down the road will compat be just by soname/version? 

6. I recently enabled the xml stuff in libnftables and am seeing a
number of tests fail: 

parsing xmlfiles/55-rule-real.xml: ^[[31mFAILED^[[0m (Invalid argument)
and
parsing xmlfiles/74-set.xml: ^[[31mFAILED^[[0m (Invalid argument)
mxml: <!-- nft add rule filter output ct secmark 0 counter --> cannot
be a second root node after <nftables>

Full build log at: 
http://kojipkgs.fedoraproject.org//packages/libnftables/0/0.4.20140111git.fc21/data/logs/x86_64/build.log

Are these expected? The Invalid argument might be because it doesn't
have nftables available in the build kernel? But the json tests
work. :( 

Thanks. Again, if I should send this somewhere else instead, just let
me know. Comments welcome here, direct email and/or in the above review
bugs. ;) 

kevin

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1.2: nftables-install.patch --]
[-- Type: text/x-patch, Size: 1676 bytes --]

diff -Nur nftables-0.0.orig/doc/Makefile.in nftables-0.0/doc/Makefile.in
--- nftables-0.0.orig/doc/Makefile.in	2013-11-29 03:29:41.000000000 -0700
+++ nftables-0.0/doc/Makefile.in	2013-11-30 14:31:33.159267834 -0700
@@ -10,11 +10,11 @@
 		@echo -e "  INSTALL\tdoc"
 		if test -n "$(mandocs-y)"; then \
 			$(MKDIR_P) $(DESTDIR)/${mandir}/man8 ;\
-			$(INSTALL) -m 755 -o root -g root $(mandocs-y) \
+			$(INSTALL) -m 755 -p $(mandocs-y) \
 					$(DESTDIR)/${mandir}/man8/ ;\
 		fi
 		if test -n "$(pdfdocs-y)"; then \
 			$(MKDIR_P) $(DESTDIR)/${pdfdir} ;\
-			$(INSTALL) -m 755 -o root -g root $(pdfdocs-y) \
+			$(INSTALL) -m 755 -p $(pdfdocs-y) \
 					$(DESTDIR)/${pdfdir}/ ;\
 		fi
diff -Nur nftables-0.0.orig/files/Makefile.in nftables-0.0/files/Makefile.in
--- nftables-0.0.orig/files/Makefile.in	2013-11-29 03:29:41.000000000 -0700
+++ nftables-0.0/files/Makefile.in	2013-11-30 14:30:35.440421941 -0700
@@ -1,4 +1,4 @@
 install:
 	@echo -e "  INSTALL\tfiles"
 	$(MKDIR_P) $(DESTDIR)/$(confdir)
-	$(INSTALL) -m 755 -o root -g root $(SUBDIR)nftables/* $(DESTDIR)/$(confdir)/
+	$(INSTALL) -m 755 -p $(SUBDIR)nftables/* $(DESTDIR)/$(confdir)/
diff -Nur nftables-0.0.orig/Makefile.rules.in nftables-0.0/Makefile.rules.in
--- nftables-0.0.orig/Makefile.rules.in	2013-11-29 03:29:41.000000000 -0700
+++ nftables-0.0/Makefile.rules.in	2013-11-30 14:26:03.461158244 -0700
@@ -61,7 +61,7 @@
 $(1)-install:
 			@echo -e "  INSTALL\t$1"
 			$(MKDIR_P) $$(DESTDIR)/$$($(1)-destdir)
-			$(INSTALL) -m 755 -o root -g root \
+			$(INSTALL) -m 755 -p \
 				$(SUBDIR)$(1) \
 				$$(DESTDIR)/$$($(1)-destdir)/$(1)
 install_targets		+= $(1)-install

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: nftables/libnftables packages for Fedora
  2014-01-12 20:40 nftables/libnftables packages for Fedora Kevin Fenzi
@ 2014-01-12 21:16 ` Arturo Borrero Gonzalez
  2014-01-13  0:05   ` Kevin Fenzi
                     ` (2 more replies)
  2014-01-13  0:17 ` Patrick McHardy
                   ` (2 subsequent siblings)
  3 siblings, 3 replies; 16+ messages in thread
From: Arturo Borrero Gonzalez @ 2014-01-12 21:16 UTC (permalink / raw)
  To: Kevin Fenzi; +Cc: Netfilter Development Mailing list

On 12 January 2014 21:40, Kevin Fenzi <kevin@scrye.com> wrote:
> Greetings.
>
> I apologize in advance if this is not the right place to discuss this.
> If it's not, please point me the right direction and I will move it
> there. :)
>
> I am packaging up libnftables/nftables for Fedora.

good to know! :)

>
> 2. There is some question about the /etc/nftables/* scripts. In Fedora
> land, things in /etc/ should be config files, but these aren't really
> config files. They call nft without a full path (/usr/sbin/nft, etc).
> Should these really be in /usr/share ? or is it expected users will
> modify them? Could you clarify the use case there?
>

There is a patch from me to address this:
http://patchwork.ozlabs.org/patch/304866/
Feel free to test it and comment.

I have the same issue in the Debian land. I applied the patch locally
in the package as a workaround.

The patch is not applied yet to upstream.

>
> 6. I recently enabled the xml stuff in libnftables and am seeing a
> number of tests fail:
>
> parsing xmlfiles/55-rule-real.xml:  [31mFAILED [0m (Invalid argument)
> and
> parsing xmlfiles/74-set.xml:  [31mFAILED [0m (Invalid argument)
> mxml: <!-- nft add rule filter output ct secmark 0 counter --> cannot
> be a second root node after <nftables>
>

I can't see the libmxml version in the build log. Which version of
libmxml are you using?
Seem that your version of libmxml treats XML comments different than
in my version (libmxml 2.6 from Debian).

Also I guess you are using an outdated snapshot of libnftables. Some
important changes happened to the XML/JSON parsers.

Anyway, thanks for the report, I'm going to review the XML parser.

>
> Are these expected? The Invalid argument might be because it doesn't
> have nftables available in the build kernel? But the json tests
> work. :(
>

Not expected at all.

These tests simply parse the XML/JSON input, they don't send anything
to the kernel.

> Thanks. Again, if I should send this somewhere else instead, just let
> me know. Comments welcome here, direct email and/or in the above review
> bugs. ;)


I think this is the right place.

Thanks.
-- 
Arturo Borrero González
--
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: nftables/libnftables packages for Fedora
  2014-01-12 21:16 ` Arturo Borrero Gonzalez
@ 2014-01-13  0:05   ` Kevin Fenzi
  2014-01-13  0:18     ` Patrick McHardy
  2014-01-13  0:11   ` Kevin Fenzi
  2014-01-13  0:25   ` Patrick McHardy
  2 siblings, 1 reply; 16+ messages in thread
From: Kevin Fenzi @ 2014-01-13  0:05 UTC (permalink / raw)
  To: Arturo Borrero Gonzalez; +Cc: netfilter-devel

[-- Attachment #1: Type: text/plain, Size: 2217 bytes --]

[ re-sending as I forgot to cc the list ] 

On Sun, 12 Jan 2014 22:16:35 +0100
Arturo Borrero Gonzalez <arturo.borrero.glez@gmail.com> wrote:

...snip...
 
> There is a patch from me to address this:
> http://patchwork.ozlabs.org/patch/304866/
> Feel free to test it and comment.
> 
> I have the same issue in the Debian land. I applied the patch locally
> in the package as a workaround.
> 
> The patch is not applied yet to upstream.

Cool. 

That addresses the part of the issue where the interpreter isn't fully
specified, but still the question is if these are config files that
users are expected to modify or are noarch scripts provided by the
package that are expected to be read-only (ie, /etc vs /usr/share)?

> > 6. I recently enabled the xml stuff in libnftables and am seeing a
> > number of tests fail:
> >
> > parsing xmlfiles/55-rule-real.xml:  [31mFAILED [0m (Invalid
> > argument) and
> > parsing xmlfiles/74-set.xml:  [31mFAILED [0m (Invalid argument)
> > mxml: <!-- nft add rule filter output ct secmark 0 counter -->
> > cannot be a second root node after <nftables>
> >
> 
> I can't see the libmxml version in the build log. Which version of
> libmxml are you using?
> Seem that your version of libmxml treats XML comments different than
> in my version (libmxml 2.6 from Debian).

2.7 here. ;) So, likely that changed between 2.6 and 2.7?

> Also I guess you are using an outdated snapshot of libnftables. Some
> important changes happened to the XML/JSON parsers.

Hum, thats the 2014-01-11 snapshot. Not very old. 

> Anyway, thanks for the report, I'm going to review the XML parser.

Thank you. 

> > Are these expected? The Invalid argument might be because it doesn't
> > have nftables available in the build kernel? But the json tests
> > work. :(
> >
> 
> Not expected at all.
> 
> These tests simply parse the XML/JSON input, they don't send anything
> to the kernel.

ok. Great 
 
> > Thanks. Again, if I should send this somewhere else instead, just
> > let me know. Comments welcome here, direct email and/or in the
> > above review bugs. ;)
> 
> 
> I think this is the right place.

Excellent. Thanks. 

kevin

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: nftables/libnftables packages for Fedora
  2014-01-12 21:16 ` Arturo Borrero Gonzalez
  2014-01-13  0:05   ` Kevin Fenzi
@ 2014-01-13  0:11   ` Kevin Fenzi
  2014-01-15  9:53     ` Pablo Neira Ayuso
  2014-01-13  0:25   ` Patrick McHardy
  2 siblings, 1 reply; 16+ messages in thread
From: Kevin Fenzi @ 2014-01-13  0:11 UTC (permalink / raw)
  To: Arturo Borrero Gonzalez, netfilter-devel

[-- Attachment #1: Type: text/plain, Size: 2217 bytes --]

[ re-sending as I forgot to cc the list ] 

On Sun, 12 Jan 2014 22:16:35 +0100
Arturo Borrero Gonzalez <arturo.borrero.glez@gmail.com> wrote:

...snip...
 
> There is a patch from me to address this:
> http://patchwork.ozlabs.org/patch/304866/
> Feel free to test it and comment.
> 
> I have the same issue in the Debian land. I applied the patch locally
> in the package as a workaround.
> 
> The patch is not applied yet to upstream.

Cool. 

That addresses the part of the issue where the interpreter isn't fully
specified, but still the question is if these are config files that
users are expected to modify or are noarch scripts provided by the
package that are expected to be read-only (ie, /etc vs /usr/share)?

> > 6. I recently enabled the xml stuff in libnftables and am seeing a
> > number of tests fail:
> >
> > parsing xmlfiles/55-rule-real.xml:  [31mFAILED [0m (Invalid
> > argument) and
> > parsing xmlfiles/74-set.xml:  [31mFAILED [0m (Invalid argument)
> > mxml: <!-- nft add rule filter output ct secmark 0 counter -->
> > cannot be a second root node after <nftables>
> >
> 
> I can't see the libmxml version in the build log. Which version of
> libmxml are you using?
> Seem that your version of libmxml treats XML comments different than
> in my version (libmxml 2.6 from Debian).

2.7 here. ;) So, likely that changed between 2.6 and 2.7?

> Also I guess you are using an outdated snapshot of libnftables. Some
> important changes happened to the XML/JSON parsers.

Hum, thats the 2014-01-11 snapshot. Not very old. 

> Anyway, thanks for the report, I'm going to review the XML parser.

Thank you. 

> > Are these expected? The Invalid argument might be because it doesn't
> > have nftables available in the build kernel? But the json tests
> > work. :(
> >
> 
> Not expected at all.
> 
> These tests simply parse the XML/JSON input, they don't send anything
> to the kernel.

ok. Great 
 
> > Thanks. Again, if I should send this somewhere else instead, just
> > let me know. Comments welcome here, direct email and/or in the
> > above review bugs. ;)
> 
> 
> I think this is the right place.

Excellent. Thanks. 

kevin

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: nftables/libnftables packages for Fedora
  2014-01-12 20:40 nftables/libnftables packages for Fedora Kevin Fenzi
  2014-01-12 21:16 ` Arturo Borrero Gonzalez
@ 2014-01-13  0:17 ` Patrick McHardy
  2014-01-13  0:29 ` Patrick McHardy
  2014-01-13  8:54 ` Jan Engelhardt
  3 siblings, 0 replies; 16+ messages in thread
From: Patrick McHardy @ 2014-01-13  0:17 UTC (permalink / raw)
  To: Kevin Fenzi; +Cc: netfilter-devel

On Sun, Jan 12, 2014 at 01:40:24PM -0700, Kevin Fenzi wrote:
> 2. There is some question about the /etc/nftables/* scripts. In Fedora
> land, things in /etc/ should be config files, but these aren't really
> config files. They call nft without a full path (/usr/sbin/nft, etc).
> Should these really be in /usr/share ? or is it expected users will
> modify them? Could you clarify the use case there?

These files are to be included, they are mainly executable for easier
testing.

> 4. nftables sets make to '-s' (ie, silent) on subdirs. It's good for
> building packages to have verbose output in build logs. Would it be
> possible to remove that? If not I can patch it out here. 

No problem adding an option to disable the silent output (I think
current autoconf supports this), but I'd like to keep it as default.

^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: nftables/libnftables packages for Fedora
  2014-01-13  0:05   ` Kevin Fenzi
@ 2014-01-13  0:18     ` Patrick McHardy
  0 siblings, 0 replies; 16+ messages in thread
From: Patrick McHardy @ 2014-01-13  0:18 UTC (permalink / raw)
  To: Kevin Fenzi; +Cc: Arturo Borrero Gonzalez, netfilter-devel

On Sun, Jan 12, 2014 at 05:05:49PM -0700, Kevin Fenzi wrote:
> [ re-sending as I forgot to cc the list ] 
> 
> On Sun, 12 Jan 2014 22:16:35 +0100
> Arturo Borrero Gonzalez <arturo.borrero.glez@gmail.com> wrote:
> 
> ...snip...
>  
> > There is a patch from me to address this:
> > http://patchwork.ozlabs.org/patch/304866/
> > Feel free to test it and comment.
> > 
> > I have the same issue in the Debian land. I applied the patch locally
> > in the package as a workaround.
> > 
> > The patch is not applied yet to upstream.
> 
> Cool. 
> 
> That addresses the part of the issue where the interpreter isn't fully
> specified, but still the question is if these are config files that
> users are expected to modify or are noarch scripts provided by the
> package that are expected to be read-only (ie, /etc vs /usr/share)?

Yes, they are basically noarch scripts providing defaults for the
table configurations.

^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: nftables/libnftables packages for Fedora
  2014-01-12 21:16 ` Arturo Borrero Gonzalez
  2014-01-13  0:05   ` Kevin Fenzi
  2014-01-13  0:11   ` Kevin Fenzi
@ 2014-01-13  0:25   ` Patrick McHardy
  2 siblings, 0 replies; 16+ messages in thread
From: Patrick McHardy @ 2014-01-13  0:25 UTC (permalink / raw)
  To: Arturo Borrero Gonzalez; +Cc: Kevin Fenzi, Netfilter Development Mailing list

On Sun, Jan 12, 2014 at 10:16:35PM +0100, Arturo Borrero Gonzalez wrote:
> On 12 January 2014 21:40, Kevin Fenzi <kevin@scrye.com> wrote:
> >
> > 2. There is some question about the /etc/nftables/* scripts. In Fedora
> > land, things in /etc/ should be config files, but these aren't really
> > config files. They call nft without a full path (/usr/sbin/nft, etc).
> > Should these really be in /usr/share ? or is it expected users will
> > modify them? Could you clarify the use case there?
> >
> 
> There is a patch from me to address this:
> http://patchwork.ozlabs.org/patch/304866/
> Feel free to test it and comment.
> 
> I have the same issue in the Debian land. I applied the patch locally
> in the package as a workaround.
> 
> The patch is not applied yet to upstream.

Could you please resubmit? I'm going to apply it to the master branch.

Thanks.

^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: nftables/libnftables packages for Fedora
  2014-01-12 20:40 nftables/libnftables packages for Fedora Kevin Fenzi
  2014-01-12 21:16 ` Arturo Borrero Gonzalez
  2014-01-13  0:17 ` Patrick McHardy
@ 2014-01-13  0:29 ` Patrick McHardy
  2014-01-13  8:54 ` Jan Engelhardt
  3 siblings, 0 replies; 16+ messages in thread
From: Patrick McHardy @ 2014-01-13  0:29 UTC (permalink / raw)
  To: Kevin Fenzi; +Cc: netfilter-devel

On Sun, Jan 12, 2014 at 01:40:24PM -0700, Kevin Fenzi wrote:
> 3. nftables hard codes installing as root, which is no good for
> building packages (patch attached that just removes the owner/group
> setting there). 

Please resubmit with a subject, a brief changelog and a Signed-off-by:
line and I'm going to apply it.

Thanks.

^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: nftables/libnftables packages for Fedora
  2014-01-12 20:40 nftables/libnftables packages for Fedora Kevin Fenzi
                   ` (2 preceding siblings ...)
  2014-01-13  0:29 ` Patrick McHardy
@ 2014-01-13  8:54 ` Jan Engelhardt
  2014-01-13  9:09   ` Patrick McHardy
  3 siblings, 1 reply; 16+ messages in thread
From: Jan Engelhardt @ 2014-01-13  8:54 UTC (permalink / raw)
  To: Kevin Fenzi; +Cc: netfilter-devel


On Sunday 2014-01-12 21:40, Kevin Fenzi wrote:
>
>1. Completely minor, but noted in review of both packages that the
>COPYING file has the old fsf address in it. Would be great if you could
>update to the new one. 
>https://fedoraproject.org/wiki/Common_Rpmlint_issues#incorrect-fsf-address

No, best remove the address, because you really don't want to be updating
all the time.

>3. nftables hard codes installing as root, which is no good for
>building packages (patch attached that just removes the owner/group
>setting there). 

Well I sent an automake-making patch that would fix all those problems,
but so far it has again been ignored to be merged.

^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: nftables/libnftables packages for Fedora
  2014-01-13  8:54 ` Jan Engelhardt
@ 2014-01-13  9:09   ` Patrick McHardy
  2014-01-13 19:18     ` Kevin Fenzi
  0 siblings, 1 reply; 16+ messages in thread
From: Patrick McHardy @ 2014-01-13  9:09 UTC (permalink / raw)
  To: Jan Engelhardt; +Cc: Kevin Fenzi, netfilter-devel

On Mon, Jan 13, 2014 at 09:54:22AM +0100, Jan Engelhardt wrote:
> 
> On Sunday 2014-01-12 21:40, Kevin Fenzi wrote:
> >
> >1. Completely minor, but noted in review of both packages that the
> >COPYING file has the old fsf address in it. Would be great if you could
> >update to the new one. 
> >https://fedoraproject.org/wiki/Common_Rpmlint_issues#incorrect-fsf-address
> 
> No, best remove the address, because you really don't want to be updating
> all the time.

"All the time" seems slightly exagerated. But the "updated" license linked
in the wiki is exactly the same version we're using, the address hasn't been
changed:

http://www.gnu.org/licenses/old-licenses/gpl-2.0.txt

^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: nftables/libnftables packages for Fedora
  2014-01-13  9:09   ` Patrick McHardy
@ 2014-01-13 19:18     ` Kevin Fenzi
  2014-01-14  8:55       ` Patrick McHardy
  0 siblings, 1 reply; 16+ messages in thread
From: Kevin Fenzi @ 2014-01-13 19:18 UTC (permalink / raw)
  To: Patrick McHardy; +Cc: Jan Engelhardt, netfilter-devel

[-- Attachment #1: Type: text/plain, Size: 1400 bytes --]

On Mon, 13 Jan 2014 09:09:43 +0000
Patrick McHardy <kaber@trash.net> wrote:

> On Mon, Jan 13, 2014 at 09:54:22AM +0100, Jan Engelhardt wrote:
> > 
> > On Sunday 2014-01-12 21:40, Kevin Fenzi wrote:
> > >
> > >1. Completely minor, but noted in review of both packages that the
> > >COPYING file has the old fsf address in it. Would be great if you
> > >could update to the new one. 
> > >https://fedoraproject.org/wiki/Common_Rpmlint_issues#incorrect-fsf-address
> > 
> > No, best remove the address, because you really don't want to be
> > updating all the time.
> 
> "All the time" seems slightly exagerated. But the "updated" license
> linked in the wiki is exactly the same version we're using, the
> address hasn't been changed:
> 
> http://www.gnu.org/licenses/old-licenses/gpl-2.0.txt

It has: 

- Copyright (C) 1989, 1991 Free Software Foundation, Inc.
-                          675 Mass Ave, Cambridge, MA 02139, USA
+ Copyright (C) 1989, 1991 Free Software Foundation, Inc.,
+ 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA

... and a few other diffs like saying <yeah> instead of 19xx and Lesser
GNU Public License instead of Library, etc. 

FSF moved buildings a few years ago... as far as I know they don't plan
to move again, and it's only happened once. The GPLv3 COPYING file I
note doesn't have any physical address in it. ;) 

kevin

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: nftables/libnftables packages for Fedora
  2014-01-13 19:18     ` Kevin Fenzi
@ 2014-01-14  8:55       ` Patrick McHardy
  2014-01-14 18:28         ` Kevin Fenzi
  0 siblings, 1 reply; 16+ messages in thread
From: Patrick McHardy @ 2014-01-14  8:55 UTC (permalink / raw)
  To: Kevin Fenzi; +Cc: Jan Engelhardt, netfilter-devel

On Mon, Jan 13, 2014 at 12:18:36PM -0700, Kevin Fenzi wrote:
> On Mon, 13 Jan 2014 09:09:43 +0000
> Patrick McHardy <kaber@trash.net> wrote:
> 
> > On Mon, Jan 13, 2014 at 09:54:22AM +0100, Jan Engelhardt wrote:
> > > 
> > > On Sunday 2014-01-12 21:40, Kevin Fenzi wrote:
> > > >
> > > >1. Completely minor, but noted in review of both packages that the
> > > >COPYING file has the old fsf address in it. Would be great if you
> > > >could update to the new one. 
> > > >https://fedoraproject.org/wiki/Common_Rpmlint_issues#incorrect-fsf-address
> > > 
> > > No, best remove the address, because you really don't want to be
> > > updating all the time.
> > 
> > "All the time" seems slightly exagerated. But the "updated" license
> > linked in the wiki is exactly the same version we're using, the
> > address hasn't been changed:
> > 
> > http://www.gnu.org/licenses/old-licenses/gpl-2.0.txt
> 
> It has: 
> 
> - Copyright (C) 1989, 1991 Free Software Foundation, Inc.
> -                          675 Mass Ave, Cambridge, MA 02139, USA
> + Copyright (C) 1989, 1991 Free Software Foundation, Inc.,
> + 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA
> 
> ... and a few other diffs like saying <yeah> instead of 19xx and Lesser
> GNU Public License instead of Library, etc. 

That's what we have (and always had) in nftables:

 Copyright (C) 1989, 1991 Free Software Foundation, Inc.
               51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA

> FSF moved buildings a few years ago... as far as I know they don't plan
> to move again, and it's only happened once. The GPLv3 COPYING file I
> note doesn't have any physical address in it. ;) 
> 
> kevin



^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: nftables/libnftables packages for Fedora
  2014-01-14  8:55       ` Patrick McHardy
@ 2014-01-14 18:28         ` Kevin Fenzi
  2014-01-14 18:34           ` Pablo Neira Ayuso
  0 siblings, 1 reply; 16+ messages in thread
From: Kevin Fenzi @ 2014-01-14 18:28 UTC (permalink / raw)
  To: Patrick McHardy; +Cc: Jan Engelhardt, netfilter-devel

[-- Attachment #1: Type: text/plain, Size: 226 bytes --]

On Tue, 14 Jan 2014 08:55:33 +0000
Patrick McHardy <kaber@trash.net> wrote:

> That's what we have (and always had) in nftables:

Indeed, it's libnftables that has the old one. 

Sorry for the confusion... 

kevin


[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: nftables/libnftables packages for Fedora
  2014-01-14 18:28         ` Kevin Fenzi
@ 2014-01-14 18:34           ` Pablo Neira Ayuso
  0 siblings, 0 replies; 16+ messages in thread
From: Pablo Neira Ayuso @ 2014-01-14 18:34 UTC (permalink / raw)
  To: Kevin Fenzi; +Cc: Patrick McHardy, Jan Engelhardt, netfilter-devel

[-- Attachment #1: Type: text/plain, Size: 277 bytes --]

On Tue, Jan 14, 2014 at 11:28:16AM -0700, Kevin Fenzi wrote:
> On Tue, 14 Jan 2014 08:55:33 +0000
> Patrick McHardy <kaber@trash.net> wrote:
> 
> > That's what we have (and always had) in nftables:
> 
> Indeed, it's libnftables that has the old one. 

Patch attached.

[-- Attachment #2: x --]
[-- Type: text/plain, Size: 1373 bytes --]

diff --git a/COPYING b/COPYING
index a43ea21..21b9363 100644
--- a/COPYING
+++ b/COPYING
@@ -2,7 +2,7 @@
 		       Version 2, June 1991
 
  Copyright (C) 1989, 1991 Free Software Foundation, Inc.
-                          675 Mass Ave, Cambridge, MA 02139, USA
+               51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA
  Everyone is permitted to copy and distribute verbatim copies
  of this license document, but changing it is not allowed.
 
@@ -278,8 +278,9 @@ PROGRAMS), EVEN IF SUCH HOLDER OR OTHER PARTY HAS BEEN ADVISED OF THE
 POSSIBILITY OF SUCH DAMAGES.
 
 		     END OF TERMS AND CONDITIONS
-\f
-	Appendix: How to Apply These Terms to Your New Programs
+
+
+	    How to Apply These Terms to Your New Programs
 
   If you develop a new program, and you want it to be of the greatest
 possible use to the public, the best way to achieve this is to make it
@@ -305,7 +306,8 @@ the "copyright" line and a pointer to where the full notice is found.
 
     You should have received a copy of the GNU General Public License
     along with this program; if not, write to the Free Software
-    Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA.
+    Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301  USA
+
 
 Also add information on how to contact you by electronic and paper mail.
 

^ permalink raw reply related	[flat|nested] 16+ messages in thread

* Re: nftables/libnftables packages for Fedora
  2014-01-13  0:11   ` Kevin Fenzi
@ 2014-01-15  9:53     ` Pablo Neira Ayuso
  2014-01-15 10:18       ` Arturo Borrero Gonzalez
  0 siblings, 1 reply; 16+ messages in thread
From: Pablo Neira Ayuso @ 2014-01-15  9:53 UTC (permalink / raw)
  To: Kevin Fenzi; +Cc: Arturo Borrero Gonzalez, netfilter-devel

Hi,

On Sun, Jan 12, 2014 at 05:11:16PM -0700, Kevin Fenzi wrote:
> [ re-sending as I forgot to cc the list ] 
> 
> On Sun, 12 Jan 2014 22:16:35 +0100
> Arturo Borrero Gonzalez <arturo.borrero.glez@gmail.com> wrote:
> 
> ...snip...
>  
> > There is a patch from me to address this:
> > http://patchwork.ozlabs.org/patch/304866/
> > Feel free to test it and comment.
> > 
> > I have the same issue in the Debian land. I applied the patch locally
> > in the package as a workaround.
> > 
> > The patch is not applied yet to upstream.
> 
> Cool. 
> 
> That addresses the part of the issue where the interpreter isn't fully
> specified, but still the question is if these are config files that
> users are expected to modify or are noarch scripts provided by the
> package that are expected to be read-only (ie, /etc vs /usr/share)?
> 
> > > 6. I recently enabled the xml stuff in libnftables and am seeing a
> > > number of tests fail:
> > >
> > > parsing xmlfiles/55-rule-real.xml:  [31mFAILED [0m (Invalid
> > > argument) and
> > > parsing xmlfiles/74-set.xml:  [31mFAILED [0m (Invalid argument)
> > > mxml: <!-- nft add rule filter output ct secmark 0 counter -->
> > > cannot be a second root node after <nftables>
> > >
> > 
> > I can't see the libmxml version in the build log. Which version of
> > libmxml are you using?
> > Seem that your version of libmxml treats XML comments different than
> > in my version (libmxml 2.6 from Debian).
> 
> 2.7 here. ;) So, likely that changed between 2.6 and 2.7?

@Arturo: please investigate this issue as the first release is coming
soon, otherwise we'll have to restrict xml support to one of the
libmxml versions. I think it would be better if libnftables supports
latest version of libmxml as it's the natural move on most
distributions to pack the last software version. Moreover, it would be
good to contact the author to know if he has plans to keep a stable
API/ABI in upcoming releases of libmxml, this is very important for
third party software.

^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: nftables/libnftables packages for Fedora
  2014-01-15  9:53     ` Pablo Neira Ayuso
@ 2014-01-15 10:18       ` Arturo Borrero Gonzalez
  0 siblings, 0 replies; 16+ messages in thread
From: Arturo Borrero Gonzalez @ 2014-01-15 10:18 UTC (permalink / raw)
  To: Pablo Neira Ayuso; +Cc: Kevin Fenzi, Netfilter Development Mailing list

On 15 January 2014 10:53, Pablo Neira Ayuso <pablo@netfilter.org> wrote:
>
> @Arturo: please investigate this issue as the first release is coming
> soon, otherwise we'll have to restrict xml support to one of the
> libmxml versions. I think it would be better if libnftables supports
> latest version of libmxml as it's the natural move on most
> distributions to pack the last software version. Moreover, it would be
> good to contact the author to know if he has plans to keep a stable
> API/ABI in upcoming releases of libmxml, this is very important for
> third party software.

Sure,

I plan to make the required changes in libnftables to support the
latest version of libmxml.

-- 
Arturo Borrero González
--
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply	[flat|nested] 16+ messages in thread

end of thread, other threads:[~2014-01-15 10:18 UTC | newest]

Thread overview: 16+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-01-12 20:40 nftables/libnftables packages for Fedora Kevin Fenzi
2014-01-12 21:16 ` Arturo Borrero Gonzalez
2014-01-13  0:05   ` Kevin Fenzi
2014-01-13  0:18     ` Patrick McHardy
2014-01-13  0:11   ` Kevin Fenzi
2014-01-15  9:53     ` Pablo Neira Ayuso
2014-01-15 10:18       ` Arturo Borrero Gonzalez
2014-01-13  0:25   ` Patrick McHardy
2014-01-13  0:17 ` Patrick McHardy
2014-01-13  0:29 ` Patrick McHardy
2014-01-13  8:54 ` Jan Engelhardt
2014-01-13  9:09   ` Patrick McHardy
2014-01-13 19:18     ` Kevin Fenzi
2014-01-14  8:55       ` Patrick McHardy
2014-01-14 18:28         ` Kevin Fenzi
2014-01-14 18:34           ` Pablo Neira Ayuso

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).