netfilter-devel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH netfilter: nf_ct] Fix compilation warning if NF_CONNTRACK_MARK is not set
@ 2014-01-10 20:43 Kristian Evensen
  2014-01-15 10:35 ` Pablo Neira Ayuso
  0 siblings, 1 reply; 2+ messages in thread
From: Kristian Evensen @ 2014-01-10 20:43 UTC (permalink / raw)
  To: netfilter-devel; +Cc: Kristian Evensen

From: Kristian Evensen <kristian.evensen@gmail.com>

net/netfilter/nft_ct.c: In function 'nft_ct_set_eval':
net/netfilter/nft_ct.c:136:6: warning: unused variable 'value' [-Wunused-variable]

Reported-by: kbuild test robot <fengguang.wu@intel.com>
Signed-off-by: Kristian Evensen <kristian.evensen@gmail.com>
---
 net/netfilter/nft_ct.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/net/netfilter/nft_ct.c b/net/netfilter/nft_ct.c
index c7c1285..917052e 100644
--- a/net/netfilter/nft_ct.c
+++ b/net/netfilter/nft_ct.c
@@ -133,7 +133,9 @@ static void nft_ct_set_eval(const struct nft_expr *expr,
 {
 	const struct nft_ct *priv = nft_expr_priv(expr);
 	struct sk_buff *skb = pkt->skb;
+#ifdef CONFIG_NF_CONNTRACK_MARK
 	u32 value = data[priv->sreg].data[0];
+#endif
 	enum ip_conntrack_info ctinfo;
 	struct nf_conn *ct;
 
-- 
1.8.3.2


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH netfilter: nf_ct] Fix compilation warning if NF_CONNTRACK_MARK is not set
  2014-01-10 20:43 [PATCH netfilter: nf_ct] Fix compilation warning if NF_CONNTRACK_MARK is not set Kristian Evensen
@ 2014-01-15 10:35 ` Pablo Neira Ayuso
  0 siblings, 0 replies; 2+ messages in thread
From: Pablo Neira Ayuso @ 2014-01-15 10:35 UTC (permalink / raw)
  To: Kristian Evensen; +Cc: netfilter-devel

On Fri, Jan 10, 2014 at 09:43:20PM +0100, Kristian Evensen wrote:
> From: Kristian Evensen <kristian.evensen@gmail.com>
> 
> net/netfilter/nft_ct.c: In function 'nft_ct_set_eval':
> net/netfilter/nft_ct.c:136:6: warning: unused variable 'value' [-Wunused-variable]

Applied, thanks.

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2014-01-15 10:36 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-01-10 20:43 [PATCH netfilter: nf_ct] Fix compilation warning if NF_CONNTRACK_MARK is not set Kristian Evensen
2014-01-15 10:35 ` Pablo Neira Ayuso

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).