Re: [PATCH nft] segtree: add new segtree debugging option

[Pablo Neira Ayuso <pablo@netfilter.org>]

On Wed, Jan 15, 2014 at 03:06:24PM +0000, Patrick McHardy wrote:
> On Wed, Jan 15, 2014 at 04:03:00PM +0100, Pablo Neira Ayuso wrote:
> > On Wed, Jan 15, 2014 at 02:48:10PM +0000, Patrick McHardy wrote:
> > > On Wed, Jan 15, 2014 at 01:25:04PM +0100, Pablo Neira Ayuso wrote:
> > > > Currently, nft displays the debugging information if it's compiled with
> > > > --enable-debug (which seems a good idea) and when intervals are used
> > > > in maps. Add a new option to enable debugging to segtree, so we only
> > > > get this information when explicitly requested.
> > > > 
> > > > Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
> > > > ---
> > > > We need this in master to avoid inconditional display of the
> > > > debugging information when --enable-debug is passed at configuration
> > > > / compilation time. I'm aware this patch conflicts with next-3.14,
> > > > that conflict should be easy to resolve.
> > > 
> > > Looks good, thanks, I wanted to change this myself.
> > 
> > Just pushed it, thanks.
> > 
> > > A few more things about debugging, some are easy, some might be a bit more
> > > work:
> > > 
> > > - we should use stdout for netlink rule debugging
> > 
> > OK, pushed another small patch for this.
> > 
> > > - netlink rule debugging is very very verbose since it dumps the entire
> > >   netlink message. I'd prefer to only have the netlink expressions
> > >   ([meta load ...]) and have the netlink message as another option.
> > >   It keeps scrolling everything off the screen.
> > 
> > Fine with me. I'd like to keep that there as option, it has helped me
> > to debug some issues in the past. Will check this.
> > 
> > > - netlink message debugging colors break in less. We should check for
> > >   isatty().
> > 
> > less -R can interpret them here.
> 
> Ok that's good enough for now, though I would usually rather surpress
> them completely. Still I'd suggest to use isatty() for redirections to
> files, bugtracker entries etc.

I'll add a new interface to libmnl that accepts flags to decide if we
want colors or not. But it would take some time until distributors
pack that new version of the library and I would like to avoid that.
I'll add this to my notepad so we can revisit this later.