netfilter-devel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Patrick McHardy <kaber@trash.net>
To: pablo@netfilter.org
Cc: arturo.borrero.glez@gmail.com, netfilter-devel@vger.kernel.org
Subject: libnftables set element printing, DATA_CHAIN
Date: Wed, 15 Jan 2014 22:50:03 +0000	[thread overview]
Message-ID: <20140115225002.GA13700@macbook.localnet> (raw)

[resending because of incorrect list address]

I was looking at some incorrect output in netlink debugging for set elements
and noticed a few things that seem odd:

First, the regular netlink debugging seems very incomplete, it doesn't
print verdict types, it prints [end] whether the set contains intervals
and the set is an interval end or not and its messing up the output.

Next I'm wondering about what DATA_CHAIN is supposed to be. I guess its
the chain for a jump or goto verdict, This is even encoded in the
XML and JSON output. This seems wrong to me, there is no DATA_CHAIN,
there are JUMP or GOTO verdicts that include a chain. The specific
verdict is also missing, so its not possible to distinguish these
two cases.

I could fix up the debugging output, but this looks like someone more
familiar with the XML and JSON stuff should have a look at this and
fix all of this consistently before we release it as wire format.

             reply	other threads:[~2014-01-15 22:50 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-01-15 22:50 Patrick McHardy [this message]
2014-01-16 10:30 ` libnftables set element printing, DATA_CHAIN Arturo Borrero Gonzalez
2014-01-16 10:40   ` Patrick McHardy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140115225002.GA13700@macbook.localnet \
    --to=kaber@trash.net \
    --cc=arturo.borrero.glez@gmail.com \
    --cc=netfilter-devel@vger.kernel.org \
    --cc=pablo@netfilter.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).