From mboxrd@z Thu Jan 1 00:00:00 1970 From: Pablo Neira Ayuso Subject: Re: [PATCH nft] src: use ':' instead of '=>' in dictionaries Date: Thu, 16 Jan 2014 20:50:18 +0100 Message-ID: <20140116195018.GA24893@localhost> References: <1389893842-17821-1-git-send-email-pablo@netfilter.org> <20140116192536.GA18619@macbook.localnet> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: netfilter-devel@vger.kernel.org To: Patrick McHardy Return-path: Received: from mail.us.es ([193.147.175.20]:48741 "EHLO mail.us.es" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750750AbaAPTuc (ORCPT ); Thu, 16 Jan 2014 14:50:32 -0500 Content-Disposition: inline In-Reply-To: <20140116192536.GA18619@macbook.localnet> Sender: netfilter-devel-owner@vger.kernel.org List-ID: On Thu, Jan 16, 2014 at 07:25:36PM +0000, Patrick McHardy wrote: > On Thu, Jan 16, 2014 at 06:37:22PM +0100, Pablo Neira Ayuso wrote: > > Replace => by : to make it easier for most shell users, as > > > implies a redirection, let's avoid possible confusion that > > may result if you forget to escape it. > > > > This works fine if you don't forget to add space between the > > key and the value. If you forget to add the space, depending > > on the case, the scanner may recognize it correctly or process > > it as a string. > > > > Signed-off-by: Pablo Neira Ayuso > > --- > > Tested here with many combinations, works fine if you don't > > forget the spaces. If you do, the result in unspecified since > > depending on the combination it may accept it or spot a > > parsing error. > > Looks good. Please push to master so we can avoid conflicts with > my patch to make set flags parsable. Done. Hope it doesn't clash with them.