From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Arturo Borrero Gonzalez <arturo.borrero.glez@gmail.com>
Cc: netfilter-devel@vger.kernel.org
Subject: Re: [libnftables PATCH] utils: fix nft_str2verdict return value
Date: Sat, 18 Jan 2014 21:52:02 +0100 [thread overview]
Message-ID: <20140118205202.GA4840@localhost> (raw)
In-Reply-To: <20140118160144.20804.20179.stgit@nfdev.cica.es>
On Sat, Jan 18, 2014 at 05:01:44PM +0100, Arturo Borrero Gonzalez wrote:
> Some verdicts have a negative value.
>
> The caller of nft_str2verdict() checking if return was < 0 clash with
> enum nft_verdict.
>
> While at it, add error reporting of invalid verdicts.
Good catch, applied, thanks.
prev parent reply other threads:[~2014-01-18 20:52 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-18 16:01 [libnftables PATCH] utils: fix nft_str2verdict return value Arturo Borrero Gonzalez
2014-01-18 20:52 ` Pablo Neira Ayuso [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140118205202.GA4840@localhost \
--to=pablo@netfilter.org \
--cc=arturo.borrero.glez@gmail.com \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).