From: Patrick McHardy <kaber@trash.net>
To: Arturo Borrero Gonzalez <arturo.borrero.glez@gmail.com>
Cc: Netfilter Development Mailing list
<netfilter-devel@vger.kernel.org>,
Pablo Neira Ayuso <pablo@netfilter.org>
Subject: Re: [nft RFC PATCH] src: add export operation
Date: Tue, 21 Jan 2014 16:16:02 +0000 [thread overview]
Message-ID: <20140121161602.GA7944@macbook.localnet> (raw)
In-Reply-To: <CAOkSjBj4oXHhMjkCqcz-GhM74cekuH2TgkW+GUsM4KsgFAdk7Q@mail.gmail.com>
On Tue, Jan 21, 2014 at 05:07:39PM +0100, Arturo Borrero Gonzalez wrote:
> Thanks for your comments Patrick. I'm addressing all of them. Just one
> thing below.
>
> On 21 January 2014 15:51, Patrick McHardy <kaber@trash.net> wrote:
> >> struct cmd {
> >> struct list_head list;
> >> @@ -264,6 +267,7 @@ struct cmd {
> >> struct table *table;
> >> };
> >> const void *arg;
> >> + uint32_t format;
> >
> > No enum defined for this?
> >
>
> In libnftables, there are two: `enum nft_parse_type' and `enum nft_output_type'.
>
> I preferred just using uint32_t so we can reuse between export/import.
I see. Sure, I was just wondering.
prev parent reply other threads:[~2014-01-21 16:16 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-21 14:05 [nft RFC PATCH] src: add export operation Arturo Borrero Gonzalez
2014-01-21 14:51 ` Patrick McHardy
2014-01-21 16:07 ` Arturo Borrero Gonzalez
2014-01-21 16:16 ` Patrick McHardy [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140121161602.GA7944@macbook.localnet \
--to=kaber@trash.net \
--cc=arturo.borrero.glez@gmail.com \
--cc=netfilter-devel@vger.kernel.org \
--cc=pablo@netfilter.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).