From: Patrick McHardy <kaber@trash.net>
To: Arturo Borrero Gonzalez <arturo.borrero.glez@gmail.com>
Cc: netfilter-devel@vger.kernel.org, pablo@netfilter.org
Subject: Re: [nft RFC PATCH v2] src: add export operation
Date: Tue, 21 Jan 2014 17:26:37 +0000 [thread overview]
Message-ID: <20140121172636.GA19175@macbook.localnet> (raw)
In-Reply-To: <20140121170109.31013.94618.stgit@nfdev.cica.es>
On Tue, Jan 21, 2014 at 06:01:54PM +0100, Arturo Borrero Gonzalez wrote:
> This patch adds the following operation:
>
> :~# nft export <xml|json>
>
> The XML/JSON output is provided raw by libnftnl, thus without format.
>
> In case of XML, you can give format with the `xmllint' tool from libxml2-tools:
> :~# nft list ruleset xml | xmllint --format -
>
> In case of JSON, you can use `json_pp' from perl standar package:
> :~# nft list ruleset json | json_pp
>
> A format field is added in struct cmd, and it will be reused in the import
> operation.
>
> Signed-off-by: Arturo Borrero Gonzalez <arturo.borrero.glez@gmail.com>
> ---
> v2: address comments by Patrick: use CMD_OBJ_RULESET, move some includes, etc.
Looks fine to me. I can apply it if you want, not sure since the import
counterpart will have to wait until we have the necessary kernel changes
in place.
Please let me know.
next prev parent reply other threads:[~2014-01-21 17:26 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-21 17:01 [nft RFC PATCH v2] src: add export operation Arturo Borrero Gonzalez
2014-01-21 17:26 ` Patrick McHardy [this message]
2014-01-21 20:52 ` Arturo Borrero Gonzalez
2014-01-22 18:26 ` Patrick McHardy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140121172636.GA19175@macbook.localnet \
--to=kaber@trash.net \
--cc=arturo.borrero.glez@gmail.com \
--cc=netfilter-devel@vger.kernel.org \
--cc=pablo@netfilter.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).