From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Florian Westphal <fw@strlen.de>
Cc: Andrey Wagin <avagin@gmail.com>,
netfilter-devel@vger.kernel.org,
Patrick McHardy <kaber@trash.net>,
vvs@openvz.org, Cyrill Gorcunov <gorcunov@openvz.org>
Subject: Re: A conntrack, which is added via ctnetlink, can provoke a race condition
Date: Mon, 3 Feb 2014 00:41:55 +0100 [thread overview]
Message-ID: <20140202234155.GA6616@localhost> (raw)
In-Reply-To: <20140107123200.GE9894@breakpoint.cc>
On Tue, Jan 07, 2014 at 01:32:00PM +0100, Florian Westphal wrote:
> Andrey Wagin <avagin@gmail.com> wrote:
> > When a conntrack is created by kernel, it is initialized (sets
> > IPS_{DST,SRC}_NAT_DONE_BIT bits in nf_nat_setup_info) and only then it
> > is added in hashes (__nf_conntrack_hash_insert), so one conntract
> > can't be initialized from a few threads concurrently.
> >
> > ctnetlink can add an uninitialized conntrack (w/o
> > IPS_{DST,SRC}_NAT_DONE_BIT) in hashes, then a few threads can look up
> > this conntrack and start initialize it concurrently. It's dangerous,
> > because BUG can be triggered from nf_nat_setup_info.
>
> Good catch.
>
> I don't see a good solution at the moment.
>
> We can force null bindings if no nat transformation is specified
> from userspace. But this would mean that rules specified in the nat
> table are not evaluated anymore when the first packet arrives.
conntracks that are added via ctnetlink should already include the nat
information (if any) at creation time, this is how it works with
state-sync via conntrackd when nat is present. I think attaching the
null binding seems like the easier solution to me.
prev parent reply other threads:[~2014-02-02 23:42 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-07 9:40 A conntrack, which is added via ctnetlink, can provoke a race condition Andrey Wagin
2014-01-07 12:32 ` Florian Westphal
2014-02-02 23:41 ` Pablo Neira Ayuso [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140202234155.GA6616@localhost \
--to=pablo@netfilter.org \
--cc=avagin@gmail.com \
--cc=fw@strlen.de \
--cc=gorcunov@openvz.org \
--cc=kaber@trash.net \
--cc=netfilter-devel@vger.kernel.org \
--cc=vvs@openvz.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).