netfilter-devel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Florian Westphal <fw@strlen.de>
To: Pablo Neira Ayuso <pablo@netfilter.org>
Cc: Florian Westphal <fw@strlen.de>,
	netfilter-devel@vger.kernel.org, avagin@parallels.com,
	eric.dumazet@gmail.com
Subject: Re: [PATCH] netfilter: nf_conntrack: don't release a conntrack with non-zero refcnt
Date: Tue, 4 Feb 2014 14:27:37 +0100	[thread overview]
Message-ID: <20140204132737.GB9881@breakpoint.cc> (raw)
In-Reply-To: <20140204131602.GA22968@localhost>

Pablo Neira Ayuso <pablo@netfilter.org> wrote:
> > I think you could just leave hash_check_insert() alone?
> 
> hash_check_insert() is only used by ctnetlink in the creation path for
> new conntracks.

I see.  In that case I see nothing wrong with your patch.

Thanks for explaining!

  reply	other threads:[~2014-02-04 13:27 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-02-03 22:09 [PATCH] netfilter: nf_conntrack: don't release a conntrack with non-zero refcnt Pablo Neira Ayuso
2014-02-03 23:29 ` Florian Westphal
2014-02-04 10:21   ` Pablo Neira Ayuso
2014-02-04 12:46     ` Florian Westphal
2014-02-04 13:16       ` Pablo Neira Ayuso
2014-02-04 13:27         ` Florian Westphal [this message]
2014-02-04  0:39 ` Eric Dumazet
2014-02-05 23:00   ` Pablo Neira Ayuso
2014-02-04 13:53 ` Andrew Vagin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140204132737.GB9881@breakpoint.cc \
    --to=fw@strlen.de \
    --cc=avagin@parallels.com \
    --cc=eric.dumazet@gmail.com \
    --cc=netfilter-devel@vger.kernel.org \
    --cc=pablo@netfilter.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).