From: Patrick McHardy <kaber@trash.net>
To: Eric Leblond <eric@regit.org>
Cc: pablo@netfilter.org, netfilter-devel@vger.kernel.org
Subject: netfilter: REJECT: separate reusable code
Date: Wed, 5 Feb 2014 10:25:48 +0000 [thread overview]
Message-ID: <20140205102547.GA20930@macbook.localnet> (raw)
Just noticed commit cc70d069 (netfilter: REJECT: separate reusable code).
That doesn't look like a good idea to me at all.
First of all, it introduces static non-inline functions into a header file,
which is obviously wrong. But more importantly, it adds a symbol dependency
of the reject module on IPv6. We've tried hard to get rid of all these in
x_tables, lets please not re-add them in nftables.
I think we should instead use AF-specific modules for things like that.
We share basically no code except the boiler plate. I'd suggest to add
an AF-specific expression type lookup mechanism that takes precedence
over generic types.
Any other opinions? I wouldn't mind taking care of this myself.
next reply other threads:[~2014-02-05 10:25 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-05 10:25 Patrick McHardy [this message]
2014-02-05 10:42 ` netfilter: REJECT: separate reusable code Pablo Neira Ayuso
2014-02-05 10:53 ` Patrick McHardy
2014-02-05 11:17 ` Pablo Neira Ayuso
2014-02-05 11:49 ` Arturo Borrero Gonzalez
2014-02-05 11:50 ` Arturo Borrero Gonzalez
2014-02-05 12:04 ` Patrick McHardy
2014-02-05 12:01 ` Patrick McHardy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140205102547.GA20930@macbook.localnet \
--to=kaber@trash.net \
--cc=eric@regit.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=pablo@netfilter.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).