From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Patrick McHardy <kaber@trash.net>
Cc: Eric Leblond <eric@regit.org>, netfilter-devel@vger.kernel.org
Subject: Re: netfilter: REJECT: separate reusable code
Date: Wed, 5 Feb 2014 11:42:47 +0100 [thread overview]
Message-ID: <20140205104247.GA4458@localhost> (raw)
In-Reply-To: <20140205102547.GA20930@macbook.localnet>
On Wed, Feb 05, 2014 at 10:25:48AM +0000, Patrick McHardy wrote:
> Just noticed commit cc70d069 (netfilter: REJECT: separate reusable code).
> That doesn't look like a good idea to me at all.
>
> First of all, it introduces static non-inline functions into a header file,
> which is obviously wrong. But more importantly, it adds a symbol dependency
> of the reject module on IPv6. We've tried hard to get rid of all these in
> x_tables, lets please not re-add them in nftables.
Well, I think this is working at this moment, we can improve it of
course.
> I think we should instead use AF-specific modules for things like that.
> We share basically no code except the boiler plate. I'd suggest to add
> an AF-specific expression type lookup mechanism that takes precedence
> over generic types.
Yes, this looks like the way to go to me.
How do you plan to handle this with the inet table? We don't have
family context there.
next prev parent reply other threads:[~2014-02-05 10:42 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-05 10:25 netfilter: REJECT: separate reusable code Patrick McHardy
2014-02-05 10:42 ` Pablo Neira Ayuso [this message]
2014-02-05 10:53 ` Patrick McHardy
2014-02-05 11:17 ` Pablo Neira Ayuso
2014-02-05 11:49 ` Arturo Borrero Gonzalez
2014-02-05 11:50 ` Arturo Borrero Gonzalez
2014-02-05 12:04 ` Patrick McHardy
2014-02-05 12:01 ` Patrick McHardy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140205104247.GA4458@localhost \
--to=pablo@netfilter.org \
--cc=eric@regit.org \
--cc=kaber@trash.net \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).