From: Patrick McHardy <kaber@trash.net>
To: Arturo Borrero Gonzalez <arturo.borrero.glez@gmail.com>
Cc: netfilter-devel@vger.kernel.org, pablo@netfilter.org
Subject: Re: [RFC libnftnl PATCH 0/2] New mnlio functions
Date: Wed, 5 Feb 2014 19:24:01 +0000 [thread overview]
Message-ID: <20140205192401.GA9077@macbook.localnet> (raw)
In-Reply-To: <20140205191711.9979.23980.stgit@nfdev.cica.es>
On Wed, Feb 05, 2014 at 08:17:41PM +0100, Arturo Borrero Gonzalez wrote:
> These functions are likely to be reused by almost all programs
> that want to talk with the kernel subsystem.
>
> We can add here to libnftnl or maybe put in a higher level library.
>
> Let this patchset be a RFC about this subject.
>
> An example of what means using the new mnlio approach is the
> examples/nft-rule-add.c file. We save lots of LOCs.
>
> Comments welcome.
I agree, they belong in libnftnl. Thanks for doing this work.
>
> NOTE: this patchset would require several iterations. For example,
> I left behind batch_pages.
> ---
>
> Arturo Borrero Gonzalez (2):
> src: add mnlio API functions
> examples: use new mnlio API in nft-rule-add.c
>
>
> examples/nft-rule-add.c | 87 ----
> include/libnftnl/Makefile.am | 3
> include/libnftnl/mnlio.h | 92 ++++
> src/Makefile.am | 1
> src/libnftnl.map | 37 ++
> src/mnlio.c | 957 ++++++++++++++++++++++++++++++++++++++++++
> 6 files changed, 1096 insertions(+), 81 deletions(-)
> create mode 100644 include/libnftnl/mnlio.h
> create mode 100644 src/mnlio.c
prev parent reply other threads:[~2014-02-05 19:24 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-05 19:17 [RFC libnftnl PATCH 0/2] New mnlio functions Arturo Borrero Gonzalez
2014-02-05 19:17 ` [RFC libnftnl PATCH 1/2] src: add mnlio API functions Arturo Borrero Gonzalez
2014-02-12 14:03 ` Pablo Neira Ayuso
2014-02-05 19:17 ` [RFC libnftnl PATCH 2/2] examples: use new mnlio API in nft-rule-add.c Arturo Borrero Gonzalez
2014-02-05 19:24 ` Patrick McHardy [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140205192401.GA9077@macbook.localnet \
--to=kaber@trash.net \
--cc=arturo.borrero.glez@gmail.com \
--cc=netfilter-devel@vger.kernel.org \
--cc=pablo@netfilter.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).