From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Patrick McHardy <kaber@trash.net>
Cc: netfilter-devel@vger.kernel.org, arturo.borrero.glez@gmail.com
Subject: Re: [PATCH] netfilter: nf_tables: fix racy rule deletion
Date: Thu, 6 Feb 2014 00:02:00 +0100 [thread overview]
Message-ID: <20140205230200.GA3849@localhost> (raw)
In-Reply-To: <20140125171451.GA11373@macbook.localnet>
> --- a/net/netfilter/nf_tables_api.c
> +++ b/net/netfilter/nf_tables_api.c
> @@ -1989,13 +1992,13 @@ static int nf_tables_set_alloc_name(struct nft_ctx *ctx, struct nft_set *set,
>
> if (!sscanf(i->name, name, &tmp))
> continue;
> - if (tmp < 0 || tmp > BITS_PER_LONG * PAGE_SIZE)
> + if (tmp < 0 || tmp >= BITS_PER_BYTE * PAGE_SIZE)
> continue;
>
> set_bit(tmp, inuse);
> }
>
> - n = find_first_zero_bit(inuse, BITS_PER_LONG * PAGE_SIZE);
> + n = find_first_zero_bit(inuse, BITS_PER_BYTE * PAGE_SIZE);
> free_page((unsigned long)inuse);
> }
>
Enqueued this chunk as fix for David, thanks Patrick.
next prev parent reply other threads:[~2014-02-05 23:02 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-25 13:03 [PATCH] netfilter: nf_tables: fix racy rule deletion Pablo Neira Ayuso
2014-01-25 13:55 ` Patrick McHardy
2014-01-25 16:35 ` Patrick McHardy
2014-01-25 17:14 ` Patrick McHardy
2014-01-26 8:54 ` Pablo Neira Ayuso
2014-01-26 12:23 ` Patrick McHardy
2014-02-05 23:02 ` Pablo Neira Ayuso [this message]
2014-02-05 15:48 ` Patrick McHardy
2014-02-05 16:38 ` Pablo Neira Ayuso
2014-02-05 16:48 ` Patrick McHardy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140205230200.GA3849@localhost \
--to=pablo@netfilter.org \
--cc=arturo.borrero.glez@gmail.com \
--cc=kaber@trash.net \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).