From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Patrick McHardy <kaber@trash.net>
Cc: netfilter-devel@vger.kernel.org
Subject: Re: [PATCH 1/5] netfilter: nf_tables: fix potential oops when dumping sets
Date: Thu, 6 Feb 2014 00:23:49 +0100 [thread overview]
Message-ID: <20140205232349.GA5674@localhost> (raw)
In-Reply-To: <1391612619-30347-2-git-send-email-kaber@trash.net>
On Wed, Feb 05, 2014 at 03:03:35PM +0000, Patrick McHardy wrote:
> Commit c9c8e48597 (netfilter: nf_tables: dump sets in all existing families)
> changed nft_ctx_init_from_setattr() to only look up the address family if it
> is not NFPROTO_UNSPEC. However if it is NFPROTO_UNSPEC and a table attribute
> is given, nftables_afinfo_lookup() will dereference the NULL afi pointer.
>
> Fix by checking for non-NULL afi and also move a check added by that commit
> to the proper position.
Applied, thanks.
next prev parent reply other threads:[~2014-02-05 23:24 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-05 15:03 [PATCH 0/5] netfilter: nf_tables fixes Patrick McHardy
2014-02-05 15:03 ` [PATCH 1/5] netfilter: nf_tables: fix potential oops when dumping sets Patrick McHardy
2014-02-05 23:23 ` Pablo Neira Ayuso [this message]
2014-02-05 15:03 ` [PATCH 2/5] netfilter: nft_ct: fix missing NFT_CT_L3PROTOCOL key in validity checks Patrick McHardy
2014-02-05 23:24 ` Pablo Neira Ayuso
2014-02-05 15:03 ` [PATCH 3/5] netfilter: nf_tables: add AF specific expression support Patrick McHardy
2014-02-05 23:24 ` Pablo Neira Ayuso
2014-02-05 15:03 ` [PATCH 4/5] netfilter: nft_reject: split up reject module into IPv4 and IPv6 specifc parts Patrick McHardy
2014-02-05 23:26 ` Pablo Neira Ayuso
2014-02-06 4:53 ` Patrick McHardy
2014-02-06 8:46 ` Pablo Neira Ayuso
2014-02-05 15:03 ` [PATCH 5/5] netfilter: nf_tables: add reject module for NFPROTO_INET Patrick McHardy
2014-02-05 23:28 ` Pablo Neira Ayuso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140205232349.GA5674@localhost \
--to=pablo@netfilter.org \
--cc=kaber@trash.net \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).