From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Patrick McHardy <kaber@trash.net>
Cc: netfilter-devel@vger.kernel.org
Subject: Re: [PATCH 4/5] netfilter: nft_reject: split up reject module into IPv4 and IPv6 specifc parts
Date: Thu, 6 Feb 2014 00:26:57 +0100 [thread overview]
Message-ID: <20140205232657.GD5674@localhost> (raw)
In-Reply-To: <1391612619-30347-5-git-send-email-kaber@trash.net>
On Wed, Feb 05, 2014 at 03:03:38PM +0000, Patrick McHardy wrote:
> Currently the nft_reject module depends on symbols from ipv6. This is
> wrong since no generic module should force IPv6 support to be loaded.
> Split up the module into AF-specific and a generic part.
Applied, thanks. I have included this chunk which was missing:
--- /dev/null
+++ b/include/net/netfilter/nft_reject.h
@@ -0,0 +1,18 @@
+#ifndef _NFT_REJECT_H_
+#define _NFT_REJECT_H_
+
+struct nft_reject {
+ enum nft_reject_types type:8;
+ u8 icmp_code;
+ u8 family;
+};
+
+extern const struct nla_policy nft_reject_policy[];
+
+int nft_reject_init(const struct nft_ctx *ctx,
+ const struct nft_expr *expr,
+ const struct nlattr * const tb[]);
+
+int nft_reject_dump(struct sk_buff *skb, const struct nft_expr *expr);
+
+#endif
next prev parent reply other threads:[~2014-02-05 23:27 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-05 15:03 [PATCH 0/5] netfilter: nf_tables fixes Patrick McHardy
2014-02-05 15:03 ` [PATCH 1/5] netfilter: nf_tables: fix potential oops when dumping sets Patrick McHardy
2014-02-05 23:23 ` Pablo Neira Ayuso
2014-02-05 15:03 ` [PATCH 2/5] netfilter: nft_ct: fix missing NFT_CT_L3PROTOCOL key in validity checks Patrick McHardy
2014-02-05 23:24 ` Pablo Neira Ayuso
2014-02-05 15:03 ` [PATCH 3/5] netfilter: nf_tables: add AF specific expression support Patrick McHardy
2014-02-05 23:24 ` Pablo Neira Ayuso
2014-02-05 15:03 ` [PATCH 4/5] netfilter: nft_reject: split up reject module into IPv4 and IPv6 specifc parts Patrick McHardy
2014-02-05 23:26 ` Pablo Neira Ayuso [this message]
2014-02-06 4:53 ` Patrick McHardy
2014-02-06 8:46 ` Pablo Neira Ayuso
2014-02-05 15:03 ` [PATCH 5/5] netfilter: nf_tables: add reject module for NFPROTO_INET Patrick McHardy
2014-02-05 23:28 ` Pablo Neira Ayuso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140205232657.GD5674@localhost \
--to=pablo@netfilter.org \
--cc=kaber@trash.net \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).