From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Patrick McHardy <kaber@trash.net>
Cc: netfilter-devel@vger.kernel.org
Subject: Re: [PATCH] netfilter: nf_tables: fix log/queue expressions for NFPROTO_INET
Date: Thu, 6 Feb 2014 11:42:08 +0100 [thread overview]
Message-ID: <20140206104208.GA6589@localhost> (raw)
In-Reply-To: <1391678261-15906-1-git-send-email-kaber@trash.net>
On Thu, Feb 06, 2014 at 09:17:41AM +0000, Patrick McHardy wrote:
> The log and queue expressions both store the family during ->init() and
> use it to deliver packets. This is wrong when used in NFPROTO_INET since
> they should both deliver to the actual AF of the packet, not the dummy
> NFPROTO_INET.
>
> Use the family from the hook ops to fix this.
Applied, thanks Patrick!
prev parent reply other threads:[~2014-02-06 10:42 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-06 9:17 [PATCH] netfilter: nf_tables: fix log/queue expressions for NFPROTO_INET Patrick McHardy
2014-02-06 10:42 ` Pablo Neira Ayuso [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140206104208.GA6589@localhost \
--to=pablo@netfilter.org \
--cc=kaber@trash.net \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).