From: Pablo Neira Ayuso <pablo@netfilter.org>
To: netfilter-devel@vger.kernel.org
Cc: kaber@trash.net
Subject: Re: [PATCH] netfilter: nf_tables: fix oops when using gotos
Date: Fri, 7 Feb 2014 17:23:30 +0100 [thread overview]
Message-ID: <20140207162330.GA4917@localhost> (raw)
In-Reply-To: <1391789931-3917-1-git-send-email-pablo@netfilter.org>
On Fri, Feb 07, 2014 at 05:18:51PM +0100, Pablo Neira Ayuso wrote:
> Fix an oops if you use the "goto" operation, you will end up in
> non-base chain with no counters and no default policy. While at
> it, uninlined nft_chain_stats() since it doesn't make sense to
> optimize a debugging facility that is rarely used.
>
> Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
> ---
> I noticed this when testing the compat layer.
>
> @Patrick: When working on this I noticed I accidentally has skipped
> this patch: http://www.spinics.net/lists/netfilter-devel/msg29828.html
> I have included this change in this fix. Sorry for that.
Oops, unlined the wrong function...
next prev parent reply other threads:[~2014-02-07 16:23 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-07 16:18 [PATCH] netfilter: nf_tables: fix oops when using gotos Pablo Neira Ayuso
2014-02-07 16:23 ` Pablo Neira Ayuso [this message]
2014-02-07 16:26 ` Pablo Neira Ayuso
2014-02-07 16:30 ` Patrick McHardy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140207162330.GA4917@localhost \
--to=pablo@netfilter.org \
--cc=kaber@trash.net \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).