From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Giuseppe Longo <giuseppelng@gmail.com>
Cc: netfilter-devel@vger.kernel.org
Subject: Re: [PATCH 2/3] nft-arp: adds nft_arp_save_firewall
Date: Fri, 7 Feb 2014 19:27:18 +0100 [thread overview]
Message-ID: <20140207182718.GA4853@localhost> (raw)
In-Reply-To: <1391693471-7591-3-git-send-email-giuseppelng@gmail.com>
Hi Giuseppe,
On Thu, Feb 06, 2014 at 02:31:10PM +0100, Giuseppe Longo wrote:
> Adds nft_arp_save_firewall to arp family.
> (Avoids the segfault in xtables-events)
>
> Signed-off-by: Giuseppe Longo <giuseppelng@gmail.com>
> ---
> iptables/nft-arp.c | 9 +++++++++
> 1 file changed, 9 insertions(+)
>
> diff --git a/iptables/nft-arp.c b/iptables/nft-arp.c
> index 1710136..bbb168d 100644
> --- a/iptables/nft-arp.c
> +++ b/iptables/nft-arp.c
> @@ -570,6 +570,14 @@ after_devdst:
> fputc('\n', stdout);
> }
>
> +static void nft_arp_save_firewall(const void *data,
> + unsigned int format)
> +{
> + const struct arpt_entry *fw = data;
> +
> + return;
> +}
Please, rework patch 1/3 to make save_firewall option, ie. something
like:
...
if (ops->save_firewall)
ops->save_firewall(data, format);
Thus, you don't need this dummy function which is almost noop.
next prev parent reply other threads:[~2014-02-07 18:27 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-06 13:31 [PATCH 0/3] xtables-events segfault Giuseppe Longo
2014-02-06 13:31 ` [PATCH 1/3] nft-shared: adds save_matches_and_target Giuseppe Longo
2014-02-06 13:31 ` [PATCH 2/3] nft-arp: adds nft_arp_save_firewall Giuseppe Longo
2014-02-07 18:27 ` Pablo Neira Ayuso [this message]
2014-02-06 13:31 ` [PATCH 3/3] xtables-events: prints arp rules Giuseppe Longo
2014-02-07 18:28 ` Pablo Neira Ayuso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140207182718.GA4853@localhost \
--to=pablo@netfilter.org \
--cc=giuseppelng@gmail.com \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).