From: Florian Westphal <fw@strlen.de>
To: Jozsef Kadlecsik <kadlec@blackhole.kfki.hu>
Cc: Florian Westphal <fw@strlen.de>, netfilter-devel@vger.kernel.org
Subject: Re: [PATCH ipset 1/2] lib: fix ifname 'physdev:' prefix parsing
Date: Thu, 13 Feb 2014 12:01:01 +0100 [thread overview]
Message-ID: <20140213110101.GF25153@breakpoint.cc> (raw)
In-Reply-To: <alpine.DEB.2.10.1402131105220.16734@blackhole.kfki.hu>
Jozsef Kadlecsik <kadlec@blackhole.kfki.hu> wrote:
> Hi Florian,
>
> On Wed, 12 Feb 2014, Florian Westphal wrote:
>
> > hash:net,iface supports matching on the bridge port as well,
> > but userspace currently doesn't handle it correctly as it passes
> > in 'physdev:eth0' instead of 'eth0'+IPSET_OPT_PHYSDEV.
>
> I think the userspace does handle the case: looking at your patch, it's
> exactly the same as the original one. It is nicer, so I'm happy to apply
> it, but the description - as far as I see - doesn't fit.
It will expand to
if (strcmp("physdev:eth0", "physdev:") == 0)
which is not true.
next prev parent reply other threads:[~2014-02-13 11:01 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-12 9:27 [PATCH ipset 1/2] lib: fix ifname 'physdev:' prefix parsing Florian Westphal
2014-02-12 9:27 ` [PATCH ipset 2/2] lib: don't segfault when ipset_data_get returns NULL Florian Westphal
2014-02-13 10:14 ` Jozsef Kadlecsik
2014-02-13 11:17 ` Florian Westphal
2014-02-13 11:31 ` Jozsef Kadlecsik
2014-02-13 10:10 ` [PATCH ipset 1/2] lib: fix ifname 'physdev:' prefix parsing Jozsef Kadlecsik
2014-02-13 11:01 ` Florian Westphal [this message]
2014-02-13 11:22 ` Jozsef Kadlecsik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140213110101.GF25153@breakpoint.cc \
--to=fw@strlen.de \
--cc=kadlec@blackhole.kfki.hu \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).