From mboxrd@z Thu Jan  1 00:00:00 1970
From: Florian Westphal <fw@strlen.de>
Subject: Re: [PATCH] netfilter: nftables: fix nf_trace always-on with
 XT_TRACE=n
Date: Sun, 16 Feb 2014 11:28:24 +0100
Message-ID: <20140216102824.GC28751@breakpoint.cc>
References: <1392504525-21134-1-git-send-email-fw@strlen.de>
 <20140216102003.GA4981@localhost>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: Florian Westphal <fw@strlen.de>, netfilter-devel@vger.kernel.org
To: Pablo Neira Ayuso <pablo@netfilter.org>
Return-path: <netfilter-devel-owner@vger.kernel.org>
Received: from Chamillionaire.breakpoint.cc ([80.244.247.6]:52636 "EHLO
	Chamillionaire.breakpoint.cc" rhost-flags-OK-OK-OK-OK)
	by vger.kernel.org with ESMTP id S1751141AbaBPK20 (ORCPT
	<rfc822;netfilter-devel@vger.kernel.org>);
	Sun, 16 Feb 2014 05:28:26 -0500
Content-Disposition: inline
In-Reply-To: <20140216102003.GA4981@localhost>
Sender: netfilter-devel-owner@vger.kernel.org
List-ID: <netfilter-devel.vger.kernel.org>

Pablo Neira Ayuso <pablo@netfilter.org> wrote:
> >  static inline void nf_reset_trace(struct sk_buff *skb)
> >  {
> > -#if IS_ENABLED(CONFIG_NETFILTER_XT_TARGET_TRACE)
> > +#if IS_ENABLED(CONFIG_NETFILTER_XT_TARGET_TRACE) || defined(CONFIG_NF_TABLES)
> 
> Perhaps you can add a generic CONFIG_NF_TRACE that is set by xt_trace
> and nf_tables?

I could do that, sure, but I don't see the value in doing so.
After this patch the only place where we need to test for both
are the two places in skbuff.h.

Unless you want to make the nf_trace operations in nftables
conditional on CONFIG_NF_TRACE?

OTOH I think that trace support is a very important thing to have and I
doubt that compiling it out would save a lot of size.

But sure, if you think it makes sense I can add CONFIG_NF_TRACE and
make nf_tables tracing conditional.