From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Patrick McHardy <kaber@trash.net>
Cc: Nikolay Aleksandrov <nikolay@redhat.com>,
netfilter-devel@vger.kernel.org
Subject: Re: [PATCH v3] netfilter: nf_tables: check if payload length is a power of 2
Date: Mon, 17 Feb 2014 11:39:24 +0100 [thread overview]
Message-ID: <20140217103924.GA8090@localhost> (raw)
In-Reply-To: <20140216160954.GA12656@macbook.localnet>
On Sun, Feb 16, 2014 at 04:09:55PM +0000, Patrick McHardy wrote:
> On Sun, Feb 16, 2014 at 02:01:58PM +0100, Nikolay Aleksandrov wrote:
> > Add a check if payload's length is a power of 2 when selecting ops.
> > The fast ops were meant for well aligned loads, also this fixes a
> > small bug when using a length of 3 with some offsets which causes
> > only 1 byte to be loaded because the fast ops are chosen.
> >
> > Signed-off-by: Nikolay Aleksandrov <nikolay@redhat.com>
> > ---
> > v3: Check the length, not the offset.
> > v2: use is_power_of_2, and adjust order of checks as per Patrick's comment
> >
> > Sorry for the noise, I shouldn't hurry so much. This patch applies to
> > Dave's -net tree.
>
> Thanks!
>
> Acked-by: Patrick McHardy <kaber@trash.net>
Applied, thanks.
prev parent reply other threads:[~2014-02-17 10:39 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-16 13:01 [PATCH v3] netfilter: nf_tables: check if payload length is a power of 2 Nikolay Aleksandrov
2014-02-16 16:09 ` Patrick McHardy
2014-02-17 10:39 ` Pablo Neira Ayuso [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140217103924.GA8090@localhost \
--to=pablo@netfilter.org \
--cc=kaber@trash.net \
--cc=netfilter-devel@vger.kernel.org \
--cc=nikolay@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).