From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Florian Westphal <fw@strlen.de>
Cc: netfilter-devel@vger.kernel.org
Subject: Re: [PATCH nft] ct: direction should be integer, not bitmask
Date: Tue, 18 Feb 2014 00:09:56 +0100 [thread overview]
Message-ID: <20140217230956.GA20408@localhost> (raw)
In-Reply-To: <1392671107-6457-1-git-send-email-fw@strlen.de>
On Mon, Feb 17, 2014 at 10:05:07PM +0100, Florian Westphal wrote:
> should always generate cmp op (its enum 0, 1 in kernel).
>
> Note: 'original,reply' will no longer work after this patch.
This is also fixing the bytecode that is generated for:
nft add rule ip filter output ct direction reply counter
ip filter output 54 53
[ ct load direction => reg 1 ]
[ bitwise reg 1 = (reg=1 & 0x00000001 ) ^ 0x00000000 ]
[ cmp neq reg 1 0x00000000 ]
[ counter pkts 0 bytes 0 ]
and the output:
ct direction & reply != original counter packets 0 bytes 0
which doesn't obviously work.
To this:
ip filter output 57 56
[ ct load direction => reg 1 ]
[ cmp eq reg 1 0x00000001 ]
[ counter pkts 0 bytes 0 ]
Feel free to push it. Thanks!
Acked-by: Pablo Neira Ayuso <pablo@netfilter.org>
next prev parent reply other threads:[~2014-02-17 23:10 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-17 21:05 [PATCH nft] ct: direction should be integer, not bitmask Florian Westphal
2014-02-17 23:09 ` Pablo Neira Ayuso [this message]
2014-02-18 1:28 ` Patrick McHardy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140217230956.GA20408@localhost \
--to=pablo@netfilter.org \
--cc=fw@strlen.de \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).