Re: [nft RFC PATCH 1/6] rule: make family2str() public

[Pablo Neira Ayuso <pablo@netfilter.org>]

On Tue, Feb 18, 2014 at 12:18:11AM +0100, Arturo Borrero Gonzalez wrote:
> Make family2str() public so the function can be called from
> other files.

This patch is too small and we follow a different policy when making
patches: Export function and first usage should happen in the same
patch.

I think you can collapse this patch with 1/2.

> Signed-off-by: Arturo Borrero Gonzalez <arturo.borrero.glez@gmail.com>
> ---
>  include/rule.h |    2 ++
>  src/rule.c     |    2 +-
>  2 files changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/include/rule.h b/include/rule.h
> index e06444e..4891dc1 100644
> --- a/include/rule.h
> +++ b/include/rule.h
> @@ -125,6 +125,8 @@ extern void chain_add_hash(struct chain *chain, struct table *table);
>  extern struct chain *chain_lookup(const struct table *table,
>  				  const struct handle *h);
>  
> +extern const char *family2str(unsigned int family);
> +
>  /**
>   * struct rule - nftables rule
>   *
> diff --git a/src/rule.c b/src/rule.c
> index ab96e62..9ff2dd3 100644
> --- a/src/rule.c
> +++ b/src/rule.c
> @@ -279,7 +279,7 @@ struct chain *chain_lookup(const struct table *table, const struct handle *h)
>  	return NULL;
>  }
>  
> -static const char *family2str(unsigned int family)
> +const char *family2str(unsigned int family)
>  {
>  	switch (family) {
>  		case NFPROTO_IPV4:
>