From: Patrick McHardy <kaber@trash.net>
To: Florian Westphal <fw@strlen.de>
Cc: netfilter-devel@vger.kernel.org
Subject: Re: [PATCH nft] netlink: meta: fix wrong type in attributes
Date: Tue, 18 Feb 2014 01:27:08 +0000 [thread overview]
Message-ID: <20140218012705.GA12893@macbook.localnet> (raw)
In-Reply-To: <20140217210301.GI31125@breakpoint.cc>
On Mon, Feb 17, 2014 at 10:03:01PM +0100, Florian Westphal wrote:
> Patrick McHardy <kaber@trash.net> wrote:
> > On Mon, Feb 17, 2014 at 04:48:05PM +0100, Florian Westphal wrote:
> > > We segfault on 'list filter' when meta expr is used as _u8
> > > returns invalid register 0.
> >
> > This seems to only affect the master branch. Not sure how many people
> > are using that and if its worth doing a new release. I'd rather merge
> > the next-3.14 branch and have people use that.
>
> I am now on 0545e0c13b as head but I still get segfault:
>
> $ nft add rule filter output meta mark set 42
> $ nft list table -> segv
>
> .. and my patch should still apply afaics.
Right, we've fixed that for other types. Please push your patch to master.
We should probably add a big warning to libnftnl for these cases or
even an assert() since its misuse of the API that leads to hard to
debug problems.
next prev parent reply other threads:[~2014-02-18 1:27 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-17 15:48 [PATCH nft] netlink: meta: fix wrong type in attributes Florian Westphal
2014-02-17 17:25 ` Patrick McHardy
2014-02-17 19:14 ` Pablo Neira Ayuso
2014-02-17 19:40 ` Patrick McHardy
2014-02-17 21:03 ` Florian Westphal
2014-02-17 22:49 ` Pablo Neira Ayuso
2014-02-18 1:27 ` Patrick McHardy [this message]
2014-02-18 10:02 ` Pablo Neira Ayuso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140218012705.GA12893@macbook.localnet \
--to=kaber@trash.net \
--cc=fw@strlen.de \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).