From mboxrd@z Thu Jan 1 00:00:00 1970 From: Patrick McHardy Subject: Re: [PATCH nft] netlink: meta: fix wrong type in attributes Date: Tue, 18 Feb 2014 01:27:08 +0000 Message-ID: <20140218012705.GA12893@macbook.localnet> References: <1392652085-8225-1-git-send-email-fw@strlen.de> <20140217172559.GA9866@macbook.localnet> <20140217210301.GI31125@breakpoint.cc> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: netfilter-devel@vger.kernel.org To: Florian Westphal Return-path: Received: from stinky.trash.net ([213.144.137.162]:54596 "EHLO stinky.trash.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751154AbaBRB1P (ORCPT ); Mon, 17 Feb 2014 20:27:15 -0500 Content-Disposition: inline In-Reply-To: <20140217210301.GI31125@breakpoint.cc> Sender: netfilter-devel-owner@vger.kernel.org List-ID: On Mon, Feb 17, 2014 at 10:03:01PM +0100, Florian Westphal wrote: > Patrick McHardy wrote: > > On Mon, Feb 17, 2014 at 04:48:05PM +0100, Florian Westphal wrote: > > > We segfault on 'list filter' when meta expr is used as _u8 > > > returns invalid register 0. > > > > This seems to only affect the master branch. Not sure how many people > > are using that and if its worth doing a new release. I'd rather merge > > the next-3.14 branch and have people use that. > > I am now on 0545e0c13b as head but I still get segfault: > > $ nft add rule filter output meta mark set 42 > $ nft list table -> segv > > .. and my patch should still apply afaics. Right, we've fixed that for other types. Please push your patch to master. We should probably add a big warning to libnftnl for these cases or even an assert() since its misuse of the API that leads to hard to debug problems.