From: Patrick McHardy <kaber@trash.net>
To: Florian Westphal <fw@strlen.de>
Cc: netfilter-devel@vger.kernel.org
Subject: Re: [PATCH nft] ct: direction should be integer, not bitmask
Date: Tue, 18 Feb 2014 01:28:31 +0000 [thread overview]
Message-ID: <20140218012830.GB12893@macbook.localnet> (raw)
In-Reply-To: <1392671107-6457-1-git-send-email-fw@strlen.de>
On Mon, Feb 17, 2014 at 10:05:07PM +0100, Florian Westphal wrote:
> should always generate cmp op (its enum 0, 1 in kernel).
>
> Note: 'original,reply' will no longer work after this patch.
I agree.
>
> Signed-off-by: Florian Westphal <fw@strlen.de>
> ---
> src/ct.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/ct.c b/src/ct.c
> index f893df9..79d4666 100644
> --- a/src/ct.c
> +++ b/src/ct.c
> @@ -61,7 +61,7 @@ static const struct datatype ct_dir_type = {
> .desc = "conntrack direction",
> .byteorder = BYTEORDER_INVALID,
> .size = BITS_PER_BYTE,
> - .basetype = &bitmask_type,
> + .basetype = &integer_type,
> .sym_tbl = &ct_dir_tbl,
> };
>
> --
> 1.8.1.5
>
> --
> To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
prev parent reply other threads:[~2014-02-18 1:28 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-17 21:05 [PATCH nft] ct: direction should be integer, not bitmask Florian Westphal
2014-02-17 23:09 ` Pablo Neira Ayuso
2014-02-18 1:28 ` Patrick McHardy [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140218012830.GB12893@macbook.localnet \
--to=kaber@trash.net \
--cc=fw@strlen.de \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).