From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Patrick McHardy <kaber@trash.net>
Cc: Florian Westphal <fw@strlen.de>, netfilter-devel@vger.kernel.org
Subject: Re: [PATCH v2 -next] netfilter: nft_ct: labels get support
Date: Wed, 19 Feb 2014 11:14:51 +0100 [thread overview]
Message-ID: <20140219101451.GA9180@localhost> (raw)
In-Reply-To: <20140218144940.GB29101@macbook.localnet>
On Tue, Feb 18, 2014 at 02:49:44PM +0000, Patrick McHardy wrote:
> On Tue, Feb 18, 2014 at 03:25:32PM +0100, Florian Westphal wrote:
> > This also adds NF_CT_LABELS_MAX_SIZE so it can be re-used
> > as BUILD_BUG_ON in nft_ct.
> >
> > At this time, nft doesn't yet support writing to the label area;
> > when this changes the label->words handling needs to be moved
> > out of xt_connlabel.c into nf_conntrack_labels.c.
> >
> > Also removes a useless run-time check: words cannot grow beyond
> > 4 (32 bit) or 2 (64bit) since xt_connlabel enforces a maximum of
> > 128 labels.
> >
> > Signed-off-by: Florian Westphal <fw@strlen.de>
>
> Looks very good to me.
>
> Acked-by: Patrick McHardy <kaber@trash.net>
Applied, thanks!
prev parent reply other threads:[~2014-02-19 10:14 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-18 14:25 [PATCH v2 -next] netfilter: nft_ct: labels get support Florian Westphal
2014-02-18 14:49 ` Patrick McHardy
2014-02-19 10:14 ` Pablo Neira Ayuso [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140219101451.GA9180@localhost \
--to=pablo@netfilter.org \
--cc=fw@strlen.de \
--cc=kaber@trash.net \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).