From: Patrick McHardy <kaber@trash.net>
To: Pablo Neira Ayuso <pablo@netfilter.org>
Cc: netfilter-devel@vger.kernel.org
Subject: Re: [PATCH v2] netfilter: nf_tables: add optional user data area to rules
Date: Thu, 27 Feb 2014 11:18:34 +0000 [thread overview]
Message-ID: <20140227111834.GA5431@macbook.localnet> (raw)
In-Reply-To: <1393419861-6442-1-git-send-email-pablo@netfilter.org>
On Wed, Feb 26, 2014 at 02:04:21PM +0100, Pablo Neira Ayuso wrote:
> This allows us to store user comment strings, but it could be also
> used to store any kind of information that the user application needs
> to link to the rule.
>
> Scratch 8 bits for the new ulen field that indicates the length the
> user data area. 4 bits from the handle (so it's 42 bits long, according
> to Patrick, it would last 139 years with 1000 new rules per second)
> and 4 bits from dlen (so the expression data area is 4K, which seems
> sufficient by now even considering the compatibility layer).
>
> Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
Looks good to me.
Acked-by: Patrick McHardy <kaber@trash.net>
prev parent reply other threads:[~2014-02-27 11:18 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-26 13:04 [PATCH v2] netfilter: nf_tables: add optional user data area to rules Pablo Neira Ayuso
2014-02-27 11:18 ` Patrick McHardy [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140227111834.GA5431@macbook.localnet \
--to=kaber@trash.net \
--cc=netfilter-devel@vger.kernel.org \
--cc=pablo@netfilter.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).