netfilter-devel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Patrick McHardy <kaber@trash.net>
To: Arturo Borrero Gonzalez <arturo.borrero.glez@gmail.com>
Cc: Netfilter Development Mailing list
	<netfilter-devel@vger.kernel.org>,
	Pablo Neira Ayuso <pablo@netfilter.org>
Subject: Re: [nf_tables] suggestion: system-wide sets
Date: Thu, 27 Feb 2014 14:02:30 +0000	[thread overview]
Message-ID: <20140227140230.GA18385@macbook.localnet> (raw)
In-Reply-To: <CAOkSjBjSzf3tmdBPtXtrrcPe1xXh5S4pp4znE2ek1dEr4LzKCQ@mail.gmail.com>

On Thu, Feb 27, 2014 at 01:15:36PM +0100, Arturo Borrero Gonzalez wrote:
> Hi there!
> 
> I can't remember this subject being discussed in the near past.
> 
> Why not using system-wide sets? Or at least, family-wide sets?
> 
> >From the user point of view, I think is very interesting to define
> sets that can be used in rules all across the ruleset, same set in
> different tables and families.

Yeah, I agree. I think family wide sets and global (AF_UNSPEC) sets should
bet quite easy to add. However there's the question how to expose them
in the nft list table output. The idea is to be able to recreate the
current ruleset, including sets and elements, by parsing the output of
nft list table. If we don't include sets, the user will have to seperately
save and restore them. OTOH if we simply include global and AF-specific
sets, they will be restored once for each table and this will fail on
the second table.

Any other ideas?

> Being family-wide is what ipset does, and I'm sure is what most people
> will expect.
> 
> On the other hand, I understand this would be a major change at this point.

Should be fine. I'm thinking of keeping the table specific sets and also
having per AF and AF_UNSPEC sets. For maps we should restrict this feature
to data maps since verdicts may need a table context.

  reply	other threads:[~2014-02-27 14:02 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-02-27 12:15 [nf_tables] suggestion: system-wide sets Arturo Borrero Gonzalez
2014-02-27 14:02 ` Patrick McHardy [this message]
2014-02-27 14:46   ` Arturo Borrero Gonzalez
2014-02-27 14:58     ` Patrick McHardy
2014-03-03 10:32   ` Patrick Schaaf
2014-03-04  9:20     ` Patrick McHardy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140227140230.GA18385@macbook.localnet \
    --to=kaber@trash.net \
    --cc=arturo.borrero.glez@gmail.com \
    --cc=netfilter-devel@vger.kernel.org \
    --cc=pablo@netfilter.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).