From: Pablo Neira Ayuso <pablo@netfilter.org>
To: behanw@converseincode.com
Cc: davem@davemloft.net, kaber@trash.net, kadlec@blackhole.kfki.hu,
netfilter-devel@vger.kernel.org, netfilter@vger.kernel.org,
coreteam@netfilter.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, torvalds@linux-foundation.org,
dwmw2@infradead.org, pageexec@freemail.hu,
"Mark Charlebois" <charlebm@gmail.com>,
"Vinícius Tinti" <viniciustinti@gmail.com>
Subject: Re: [PATCH] net: inetfilter: LLVMLinux: vlais-netfilter
Date: Fri, 7 Mar 2014 18:26:27 +0100 [thread overview]
Message-ID: <20140307172627.GA4856@localhost> (raw)
In-Reply-To: <1394135768-27621-1-git-send-email-behanw@converseincode.com>
On Thu, Mar 06, 2014 at 11:56:08AM -0800, behanw@converseincode.com wrote:
> From: Mark Charlebois <charlebm@gmail.com>
>
> Replaced non-standard C use of Variable Length Arrays In Structs (VLAIS) in
> xt_repldata.h with a C99 compliant flexible array member and then calculated
> offsets to the other struct members. These other members aren't referenced by
> name in this code, however this patch maintains the same memory layout and
> padding as was previously accomplished using VLAIS.
>
> Had the original structure been ordered differently, with the entries VLA at
> the end, then it could have been a flexible member, and this patch would have
> been a lot simpler. However since the data stored in this structure is
> ultimately exported to userspace, the order of this structure can't be changed.
>
> This patch makes no attempt to change the existing behavior, merely the way in
> which the current layout is accomplished using standard C99 constructs. As such
> the code can now be compiled with either gcc or clang.
I think we already agreed on not accepting macro tricks to get this
compiling with clang:
http://comments.gmane.org/gmane.comp.security.firewalls.netfilter.devel/45138
prev parent reply other threads:[~2014-03-07 17:26 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-06 19:56 [PATCH] net: inetfilter: LLVMLinux: vlais-netfilter behanw
2014-03-07 17:26 ` Pablo Neira Ayuso [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140307172627.GA4856@localhost \
--to=pablo@netfilter.org \
--cc=behanw@converseincode.com \
--cc=charlebm@gmail.com \
--cc=coreteam@netfilter.org \
--cc=davem@davemloft.net \
--cc=dwmw2@infradead.org \
--cc=kaber@trash.net \
--cc=kadlec@blackhole.kfki.hu \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=netfilter@vger.kernel.org \
--cc=pageexec@freemail.hu \
--cc=torvalds@linux-foundation.org \
--cc=viniciustinti@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).