From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Arturo Borrero Gonzalez <arturo.borrero.glez@gmail.com>
Cc: Alvaro Neira Ayuso <alvaroneay@gmail.com>,
Netfilter Development Mailing list
<netfilter-devel@vger.kernel.org>
Subject: Re: [libnftnl PATCH 1/2] src/rule: Removed mandatory attribute printing in rules
Date: Wed, 12 Mar 2014 13:50:12 +0100 [thread overview]
Message-ID: <20140312125012.GA26001@localhost> (raw)
In-Reply-To: <CAOkSjBhtRP+aVF8qNcP0uwV4LFRFxnZCS1GCKox1uw7Vfimuew@mail.gmail.com>
On Sun, Mar 09, 2014 at 02:14:23PM +0100, Arturo Borrero Gonzalez wrote:
> On 9 March 2014 13:59, Alvaro Neira Ayuso <alvaroneay@gmail.com> wrote:
> > From: Álvaro Neira Ayuso <alvaroneay@gmail.com>
> >
> > Before this patch, the program tried to print some attribute
> > that maybe the user hasn't defined for printing. We can't
> > assume that the user want to print some attribute that we have put
> > mandatory in the rules. Example:
> >
> > Before this patch, it's mandatory have a rule with family
> > and this is the output:
> >
> > {"rule":{"family":"ip","handle":4...
> > <rule><family>ip</family><handle>4</handle>...
> >
> > Now, we can print rule without some attribute:
> >
> > {"rule":{"handle":4...
> > <rule><handle>4</handle>...
> >
> > Signed-off-by: Alvaro Neira Ayuso <alvaroneay@gmail.com>
> > ---
>
> Hi there!
>
> These attributes are no longer mandatory? What is the idea behind this?
I think we already discussed this time ago.
I'd like that the parsers don't enforce the occurrence of any
attribute, we should just let the kernel bail out if the configuration
that the user provides doesn't make sense.
This provides us more flexibility in case that we change any aspect
from the kernel side.
--
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2014-03-12 12:50 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-09 12:59 [libnftnl PATCH 1/2] src/rule: Removed mandatory attribute printing in rules Alvaro Neira Ayuso
2014-03-09 13:00 ` [libnftnl PATCH 2/2] src/rule: Changed parser support for having consistent with the new print support Alvaro Neira Ayuso
2014-03-11 20:16 ` Arturo Borrero Gonzalez
2014-03-12 11:37 ` Álvaro Neira Ayuso
2014-03-09 13:14 ` [libnftnl PATCH 1/2] src/rule: Removed mandatory attribute printing in rules Arturo Borrero Gonzalez
2014-03-12 12:50 ` Pablo Neira Ayuso [this message]
2014-03-11 19:59 ` Arturo Borrero Gonzalez
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140312125012.GA26001@localhost \
--to=pablo@netfilter.org \
--cc=alvaroneay@gmail.com \
--cc=arturo.borrero.glez@gmail.com \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).