From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Arturo Borrero Gonzalez <arturo.borrero.glez@gmail.com>
Cc: netfilter-devel@vger.kernel.org, kaber@trash.net
Subject: Re: [nft PATCH] src: fix expr_binary_error()-related compilation warnings
Date: Wed, 12 Mar 2014 17:00:06 +0100 [thread overview]
Message-ID: <20140312160006.GA533@localhost> (raw)
In-Reply-To: <20140312155322.23689.60367.stgit@nfdev.cica.es>
On Wed, Mar 12, 2014 at 04:53:22PM +0100, Arturo Borrero Gonzalez wrote:
> The commit e7b43ec0 [expr: make expr_binary_error() usable outside of evaluation]
> seem to change expr_binary_error() interface.
>
> Later, several compilation warning appears.
>
> The expr_binary_error() function and expr_error() macro both expect
> `struct list_head *', so I simply changed callers to send `ctx->msgs'.
>
> [...]
> src/evaluate.c: In function ‘byteorder_conversion’:
> src/evaluate.c:166:3: warning: passing argument 1 of ‘expr_binary_error’ from incompatible pointer type [enabled by default]
Applied, thanks Arturo.
--
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
prev parent reply other threads:[~2014-03-12 16:00 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-12 15:53 [nft PATCH] src: fix expr_binary_error()-related compilation warnings Arturo Borrero Gonzalez
2014-03-12 16:00 ` Pablo Neira Ayuso [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140312160006.GA533@localhost \
--to=pablo@netfilter.org \
--cc=arturo.borrero.glez@gmail.com \
--cc=kaber@trash.net \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).