From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Jiri Popelka <jpopelka@redhat.com>
Cc: netfilter-devel@vger.kernel.org
Subject: Re: [PATCH 3/3] iptables: save - fix getopt_long()'s optstring
Date: Fri, 14 Mar 2014 09:44:17 +0100 [thread overview]
Message-ID: <20140314084417.GA15473@localhost> (raw)
In-Reply-To: <1394726481-6001-3-git-send-email-jpopelka@redhat.com>
Hi Jiri,
On Thu, Mar 13, 2014 at 05:01:21PM +0100, Jiri Popelka wrote:
> ---
> iptables/ip6tables-save.c | 2 +-
> iptables/iptables-save.c | 2 +-
> iptables/xtables-save.c | 2 +-
> 3 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/iptables/ip6tables-save.c b/iptables/ip6tables-save.c
> index a86a64a..cf56c63 100644
> --- a/iptables/ip6tables-save.c
> +++ b/iptables/ip6tables-save.c
> @@ -137,7 +137,7 @@ int ip6tables_save_main(int argc, char *argv[])
> init_extensions6();
> #endif
>
> - while ((c = getopt_long(argc, argv, "bcdt:", options, NULL)) != -1) {
> + while ((c = getopt_long(argc, argv, "cdt:M:", options, NULL)) != -1) {
b is also removed.
My bet is that noone is using that, but just to make sure we break
some stupid script somewhere, just leave it there and add some warning
message to indicate that you can remove from your scripts. Thanks.
next prev parent reply other threads:[~2014-03-14 8:44 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-13 16:01 [PATCH 1/3] iptables-restore(8): missing -T in synopsis Jiri Popelka
2014-03-13 16:01 ` [PATCH 2/3] iptables-restore(8): file to read from can be specified as argument Jiri Popelka
2014-03-14 8:41 ` Pablo Neira Ayuso
2014-03-13 16:01 ` [PATCH 3/3] iptables: save - fix getopt_long()'s optstring Jiri Popelka
2014-03-14 8:44 ` Pablo Neira Ayuso [this message]
2014-03-14 8:40 ` [PATCH 1/3] iptables-restore(8): missing -T in synopsis Pablo Neira Ayuso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140314084417.GA15473@localhost \
--to=pablo@netfilter.org \
--cc=jpopelka@redhat.com \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).