From mboxrd@z Thu Jan 1 00:00:00 1970 From: Pablo Neira Ayuso Subject: Re: [PATCH] netlink: simplify nfnetlink_bind Date: Mon, 24 Mar 2014 12:10:44 +0100 Message-ID: <20140324111044.GC5074@localhost> References: Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: linux-audit@redhat.com, linux-kernel@vger.kernel.org, netfilter-devel@vger.kernel.org, netdev@vger.kernel.org, eparis@redhat.com, sgrubb@redhat.com, hadi@mojatatu.com, davem@davemloft.net To: Richard Guy Briggs Return-path: Received: from mail.us.es ([193.147.175.20]:44305 "EHLO mail.us.es" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752801AbaCXLKt (ORCPT ); Mon, 24 Mar 2014 07:10:49 -0400 Content-Disposition: inline In-Reply-To: Sender: netfilter-devel-owner@vger.kernel.org List-ID: On Fri, Mar 21, 2014 at 12:44:09PM -0400, Richard Guy Briggs wrote: > Remove duplicity and simplify code flow by moving the rcu_read_unlock() above > the condition and let the flow control exit naturally at the end of the > function. > > Signed-off-by: Richard Guy Briggs > --- > net/netfilter/nfnetlink.c | 4 +--- > 1 files changed, 1 insertions(+), 3 deletions(-) > > diff --git a/net/netfilter/nfnetlink.c b/net/netfilter/nfnetlink.c > index 046aa13..75619f9 100644 > --- a/net/netfilter/nfnetlink.c > +++ b/net/netfilter/nfnetlink.c > @@ -399,12 +399,10 @@ static void nfnetlink_bind(int group) > > rcu_read_lock(); > ss = nfnetlink_get_subsys(type); > + rcu_read_unlock(); > if (!ss) { > - rcu_read_unlock(); > request_module("nfnetlink-subsys-%d", type); > - return; > } > - rcu_read_unlock(); Applied with minor glitch. Removed the brackets in that if branch. Thanks