From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Tomasz Bursztyka <tomasz.bursztyka@linux.intel.com>
Cc: Giuseppe Longo <giuseppelng@gmail.com>, netfilter-devel@vger.kernel.org
Subject: Re: [nft PATCH] src: check if the set name is too long
Date: Tue, 25 Mar 2014 09:41:31 +0100 [thread overview]
Message-ID: <20140325084131.GA3857@localhost> (raw)
In-Reply-To: <53313234.6050602@linux.intel.com>
On Tue, Mar 25, 2014 at 09:37:24AM +0200, Tomasz Bursztyka wrote:
> Hi Pablo,
>
> >I sent you a patch, I think it's better if we fix this from
> >kernel-space.
>
> I think it's also good if we check the length when parsing, as Giuseppe did.
> Then it reduce the overhead: the error is detected way before we
> process anything through netlink.
This is an error case, I don't think we should focus on reducing
overhead in those scenarios.
next prev parent reply other threads:[~2014-03-25 8:41 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-21 17:39 [nft PATCH] src: check if the set name is too long Giuseppe Longo
2014-03-21 17:39 ` [PATCH] nftables: fix length of set name Giuseppe Longo
2014-03-24 14:57 ` Pablo Neira Ayuso
2014-03-24 14:57 ` [nft PATCH] src: check if the set name is too long Pablo Neira Ayuso
2014-03-25 7:37 ` Tomasz Bursztyka
2014-03-25 8:41 ` Pablo Neira Ayuso [this message]
2014-03-25 8:47 ` Pablo Neira Ayuso
-- strict thread matches above, loose matches on Subject: below --
2014-03-20 16:20 Giuseppe Longo
2014-03-21 7:24 ` Tomasz Bursztyka
2014-03-21 9:56 ` Pablo Neira Ayuso
[not found] ` <CAG7Tj4qscXJbuMU+vFo10jFmk1Reu2x+C9WMDaFQskN1t3UZ2w@mail.gmail.com>
2014-03-21 10:43 ` Tomasz Bursztyka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140325084131.GA3857@localhost \
--to=pablo@netfilter.org \
--cc=giuseppelng@gmail.com \
--cc=netfilter-devel@vger.kernel.org \
--cc=tomasz.bursztyka@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).