netfilter-devel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Patrick McHardy <kaber@trash.net>
To: Ana Rey <anarey@gmail.com>
Cc: netfilter-devel@vger.kernel.org
Subject: Re: [PATCH] nftables: Fix list of sets by family
Date: Fri, 28 Mar 2014 10:25:56 +0000	[thread overview]
Message-ID: <20140328102555.GB20105@macbook.localnet> (raw)
In-Reply-To: <dfe65abd0921773564be9ebfe55b55233380bd40.1395993386.git.anarey@gmail.com>

On Fri, Mar 28, 2014 at 08:57:54AM +0100, Ana Rey wrote:
> Fix the result of command line 'nft list sets FAMILY'. It shows the
> following error message:
> 
> "Error: syntax error, unexpected end of file, expecting string"
> 
> Use set_print function to show the list of set by family (ip, ip6, arp,
> bridge).
> 
> The set_print function is used in the following command line:
> * sudo nft list table FAMILY table_name
> * sudo nft list set FAMILY table_name set_name
> * sudo nft list sets FAMILY
> 
> In 'nft list table FAMILY table_name' and 'nft list set FAMILY
> table_name set_name' command line is necessary a extra indent that is
> not necessary in 'nft list sets FAMILY'.
> 
> Thus, It fixes this indent problem in the set_print function and now, it is
> possible show right this information:

These are two unrelated changes. Regarding the indentation, Arturro has
a patch that will also fix this in a more general way. Please seperate
the grammar fix and submit this patch, we'll fix the indentation with
Arturro's monitor feature.

Thanks!

  reply	other threads:[~2014-03-28 10:25 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-03-28  7:57 [PATCH] nftables: Fix list of sets by family Ana Rey
2014-03-28 10:25 ` Patrick McHardy [this message]
2014-03-28 11:37   ` Arturo Borrero Gonzalez
2014-03-28 11:40     ` Patrick McHardy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140328102555.GB20105@macbook.localnet \
    --to=kaber@trash.net \
    --cc=anarey@gmail.com \
    --cc=netfilter-devel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).